Skip to content

Commit ebaccc6

Browse files
committed
style update
1 parent fce244e commit ebaccc6

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

python/pyspark/ml/param/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ def _explain(self, param):
7474
param = self._resolveParam(param)
7575
values = []
7676
if self.isDefined(param):
77-
if self.defaultParamMap.has_key(param):
77+
if param in self.defaultParamMap:
7878
values.append("default: %s" % self.defaultParamMap[param])
79-
if self.paramMap.has_key(param):
79+
if param in self.paramMap:
8080
values.append("current: %s" % self.paramMap[param])
8181
else:
8282
values.append("undefined")
@@ -105,14 +105,14 @@ def isSet(self, param):
105105
Checks whether a param is explicitly set by user.
106106
"""
107107
param = self._resolveParam(param)
108-
return self.paramMap.has_key(param)
108+
return param in self.paramMap
109109

110110
def hasDefault(self, param):
111111
"""
112112
Checks whether a param has a default value.
113113
"""
114114
param = self._resolveParam(param)
115-
return self.defaultParamMap.has_key(param)
115+
return param in self.defaultParamMap
116116

117117
def isDefined(self, param):
118118
"""
@@ -126,7 +126,7 @@ def getOrDefault(self, param):
126126
default value. Raises an error if either is set.
127127
"""
128128
if isinstance(param, Param):
129-
if self.paramMap.has_key(param):
129+
if param in self.paramMap:
130130
return self.paramMap[param]
131131
else:
132132
return self.defaultParamMap[param]

python/pyspark/ml/param/_shared_params_code_gen.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
# Code generator for shared params (shared.py). Run under this folder with:
3636
# python _shared_params_code_gen.py > shared.py
3737

38+
3839
def _gen_param_code(name, doc, defaultValueStr):
3940
"""
4041
Generates Python code for a shared param class.

python/pyspark/ml/tests.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,8 @@ def test_params(self):
153153
with self.assertRaises(KeyError):
154154
testParams.getInputCol()
155155

156-
self.assertEquals(testParams.explainParams(),
156+
self.assertEquals(
157+
testParams.explainParams(),
157158
"\n".join(["inputCol: input column name (undefined)",
158159
"maxIter: max number of iterations (default: 10, current: 100)"]))
159160

0 commit comments

Comments
 (0)