Skip to content

Commit e566fe5

Browse files
watermenliancheng
authored andcommitted
[SPARK-6397][SQL] Check the missingInput simply
Author: q00251598 <[email protected]> Closes apache#5082 from watermen/sql-missingInput and squashes the following commits: 25766b9 [q00251598] Check the missingInput simply
1 parent 4659468 commit e566fe5

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,8 @@ class CheckAnalysis {
8585

8686
cleaned.foreach(checkValidAggregateExpression)
8787

88-
case o if o.children.nonEmpty &&
89-
!o.references.filter(_.name != "grouping__id").subsetOf(o.inputSet) =>
90-
val missingAttributes = (o.references -- o.inputSet).map(_.prettyString).mkString(",")
88+
case o if o.children.nonEmpty && o.missingInput.nonEmpty =>
89+
val missingAttributes = o.missingInput.map(_.prettyString).mkString(",")
9190
val input = o.inputSet.map(_.prettyString).mkString(",")
9291

9392
failAnalysis(s"resolved attributes $missingAttributes missing from $input")

sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,8 @@ case class Expand(
191191
val sizeInBytes = child.statistics.sizeInBytes * projections.length
192192
Statistics(sizeInBytes = sizeInBytes)
193193
}
194+
195+
override def missingInput = super.missingInput.filter(_.name != VirtualColumn.groupingIdName)
194196
}
195197

196198
trait GroupingAnalytics extends UnaryNode {

0 commit comments

Comments
 (0)