Skip to content

Commit dafe8d8

Browse files
committed
[SPARK-9385] [PYSPARK] Enable PEP8 but disable installing pylint.
Instead of disabling all python style check, we should enable PEP8. So, this PR just comments out the part installing pylint. Author: Yin Huai <[email protected]> Closes apache#7704 from yhuai/SPARK-9385 and squashes the following commits: 0056359 [Yin Huai] Enable PEP8 but disable installing pylint.
1 parent ab62595 commit dafe8d8

File tree

2 files changed

+17
-18
lines changed

2 files changed

+17
-18
lines changed

dev/lint-python

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -58,21 +58,21 @@ export "PYTHONPATH=$SPARK_ROOT_DIR/dev/pylint"
5858
export "PYLINT_HOME=$PYTHONPATH"
5959
export "PATH=$PYTHONPATH:$PATH"
6060

61-
if [ ! -d "$PYLINT_HOME" ]; then
62-
mkdir "$PYLINT_HOME"
63-
# Redirect the annoying pylint installation output.
64-
easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO"
65-
easy_install_status="$?"
66-
67-
if [ "$easy_install_status" -ne 0 ]; then
68-
echo "Unable to install pylint locally in \"$PYTHONPATH\"."
69-
cat "$PYLINT_INSTALL_INFO"
70-
exit "$easy_install_status"
71-
fi
72-
73-
rm "$PYLINT_INSTALL_INFO"
74-
75-
fi
61+
# if [ ! -d "$PYLINT_HOME" ]; then
62+
# mkdir "$PYLINT_HOME"
63+
# # Redirect the annoying pylint installation output.
64+
# easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO"
65+
# easy_install_status="$?"
66+
#
67+
# if [ "$easy_install_status" -ne 0 ]; then
68+
# echo "Unable to install pylint locally in \"$PYTHONPATH\"."
69+
# cat "$PYLINT_INSTALL_INFO"
70+
# exit "$easy_install_status"
71+
# fi
72+
#
73+
# rm "$PYLINT_INSTALL_INFO"
74+
#
75+
# fi
7676

7777
# There is no need to write this output to a file
7878
#+ first, but we do so so that the check status can

dev/run-tests.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,8 @@ def run_scala_style_checks():
198198

199199

200200
def run_python_style_checks():
201-
# set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE")
202-
# run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")])
203-
pass
201+
set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE")
202+
run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")])
204203

205204

206205
def build_spark_documentation():

0 commit comments

Comments
 (0)