Feedback: formatting, docs.

Author: Marcelo Vanzin

core/src/main/scala/org/apache/spark/deploy/history/ApplicationHistoryProvider.scala

@@ -25,8 +25,7 @@ private[spark] case class ApplicationHistoryInfo(
     startTime: Long,
     endTime: Long,
     lastUpdated: Long,
-    sparkUser: String) {
-}
+    sparkUser: String)
 
 private[spark] abstract class ApplicationHistoryProvider {
 

core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala

@@ -116,10 +116,9 @@ private[history] class FsHistoryProvider(conf: SparkConf) extends ApplicationHis
     try {
       val logStatus = fs.listStatus(new Path(logDir))
       val logDirs = if (logStatus != null) logStatus.filter(_.isDir).toSeq else Seq[FileStatus]()
-      val logInfos = logDirs
-        .filter {
-            dir => fs.isFile(new Path(dir.getPath(), EventLoggingListener.APPLICATION_COMPLETE))
-          }
+      val logInfos = logDirs.filter {
+        dir => fs.isFile(new Path(dir.getPath(), EventLoggingListener.APPLICATION_COMPLETE))
+      }
 
       val currentApps = Map[String, ApplicationHistoryInfo](
         appList.map(app => (app.id -> app)):_*)
@@ -177,7 +176,8 @@ private[history] class FsHistoryProvider(conf: SparkConf) extends ApplicationHis
       }
 
     replayBus.replay()
-    val appInfo = ApplicationHistoryInfo(appId,
+    val appInfo = ApplicationHistoryInfo(
+      appId,
       appListener.appName,
       appListener.startTime,
       appListener.endTime,

core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala

@@ -50,8 +50,6 @@ class HistoryServer(
   // How many applications to retain
   private val retainedApplications = conf.getInt("spark.history.retainedApplications", 50)
 
-  private val localHost = Utils.localHostName()
-
   private val appLoader = new CacheLoader[String, SparkUI] {
     override def load(key: String): SparkUI = {
       val ui = provider.getAppUI(key)
@@ -192,10 +190,10 @@ object HistoryServer {
     server.bind()
 
     Runtime.getRuntime().addShutdownHook(new Thread("HistoryServerStopper") {
-        override def run() = {
-          server.stop()
-        }
-      })
+      override def run() = {
+        server.stop()
+      }
+    })
 
     // Wait until the end of the world... or if the HistoryServer process is manually stopped
     while(true) { Thread.sleep(Int.MaxValue) }

core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala

@@ -57,17 +57,19 @@ private[spark] class HistoryServerArguments(conf: SparkConf, args: Array[String]
       |
       |History Server options:
       |
-      |  spark.history.ui.port      Port where server will listen for connections (default 18080)
-      |  spark.history.acls.enable  Whether to enable view acls for all applications (default false)
-      |  spark.history.provider     Name of history provider class (defaults to file system-based
-      |                             provider)
+      |  spark.history.ui.port              Port where server will listen for connections
+      |                                     (default 18080)
+      |  spark.history.acls.enable          Whether to enable view acls for all applications
+      |                                     (default false)
+      |  spark.history.provider             Name of history provider class (defaults to
+      |                                     file system-based provider)
       |  spark.history.retainedApplications Max number of application UIs to keep loaded in memory
-      |                             (default 50)
+      |                                     (default 50)
       |FsHistoryProvider options:
       |
-      |  spark.history.fs.logDirectory    Directory where app logs are stored (required)
-      |  spark.history.fs.updateInterval  How often to reload log data from storage (seconds,
-      |                                   default 10)
+      |  spark.history.fs.logDirectory      Directory where app logs are stored (required)
+      |  spark.history.fs.updateInterval    How often to reload log data from storage (in seconds,
+      |                                     default 10)
       |""".stripMargin)
     System.exit(exitCode)
   }

docs/monitoring.md

@@ -38,9 +38,9 @@ You can start a the history server by executing:
     ./sbin/start-history-server.sh
 
 When using the file-system provider class (see spark.history.provider below), the base logging
-directory must be supplied in the "spark.history.fs.logDirectory" configuration option, and should
-contain sub-directories that each represents an application's event logs. This creates a web
-interface at `http://<server-url>:18080` by default. The history server can be configured as
+directory must be supplied in the <code>spark.history.fs.logDirectory</code> configuration option,
+and should contain sub-directories that each represents an application's event logs. This creates a
+web interface at `http://<server-url>:18080` by default. The history server can be configured as
 follows:
 
 <table class="table">
@@ -74,7 +74,8 @@ follows:
     <td>spark.history.provider</td>
     <td>org.apache.spark.deploy.history.FsHistoryProvider</td>
     <td>Name of the class implementing the application history backend. Currently there is only
-    one implementation provided by Spark, which matches the default value.</td>
+    one implementation, provided by Spark, which looks for application logs stored in the
+    file system.</td>
   </tr>
   <tr>
     <td>spark.history.fs.updateInterval</td>