Skip to content

Commit 897141f

Browse files
author
Marcelo Vanzin
committed
Review feedback.
1 parent e2367d2 commit 897141f

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

bin/spark-shell

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ usage() {
4141
export -f usage
4242

4343
if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
44-
usage 0
44+
usage "" 0
4545
fi
4646

4747
# SPARK-4161: scala does not assume use of the java classpath,

launcher/src/main/java/org/apache/spark/launcher/Main.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ class Main {
4444
* "bin/spark-class2.cmd" batch script on Windows to execute the final command.
4545
* <p/>
4646
* On Unix-like systems, the output is a list of command arguments, separated by the NULL
47-
* character. On Windows, the output is single command line suitable for direct execution
48-
* form the script.
47+
* character. On Windows, the output is a command line suitable for direct execution from the
48+
* script.
4949
*/
5050
public static void main(String[] argsArray) throws Exception {
5151
checkArgument(argsArray.length > 0, "Not enough arguments: missing class name.");
@@ -139,7 +139,7 @@ private static List<String> prepareBashCommand(List<String> cmd, Map<String, Str
139139
}
140140

141141
/**
142-
* Internal launcher used when command line parsing fails. This will behave differently depending
142+
* Internal builder used when command line parsing fails. This will behave differently depending
143143
* on the platform:
144144
*
145145
* - On Unix-like systems, it will print a call to the "usage" function with two arguments: the

launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@
2929
import static org.apache.spark.launcher.CommandBuilderUtils.*;
3030

3131
/**
32-
* Special launcher for handling a CLI invocation of SparkSubmit.
32+
* Special command builder for handling a CLI invocation of SparkSubmit.
3333
* <p/>
34-
* This launcher extends SparkLauncher to add command line parsing compatible with
35-
* SparkSubmit. It handles setting driver-side options and special parsing needed
36-
* for the different specialClasses.
34+
* This builder adds command line parsing compatible with SparkSubmit. It handles setting
35+
* driver-side options and special parsing behavior needed for the special-casing certain internal
36+
* Spark applications.
3737
* <p/>
38-
* This class has also some special features to aid PySparkLauncher.
38+
* This class has also some special features to aid launching pyspark.
3939
*/
4040
class SparkSubmitCommandBuilder extends AbstractCommandBuilder {
4141

0 commit comments

Comments
 (0)