Skip to content

Commit 72b5006

Browse files
committed
remove generic from pipeline interface
1 parent 8bbaea0 commit 72b5006

File tree

1 file changed

+7
-8
lines changed
  • mllib/src/main/scala/org/apache/spark/ml/recommendation

1 file changed

+7
-8
lines changed

mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,12 @@ private[recommendation] trait ALSParams extends Params with HasMaxIter with HasR
102102
/**
103103
* Model fitted by ALS.
104104
*/
105-
class ALSModel[@specialized(Int, Long) UserType, @specialized(Int, Long) ItemType] private[ml] (
106-
override val parent: ALS[UserType, ItemType],
105+
class ALSModel private[ml] (
106+
override val parent: ALS,
107107
override val fittingParamMap: ParamMap,
108108
k: Int,
109-
userFactors: RDD[(UserType, Array[Float])],
110-
itemFactors: RDD[(ItemType, Array[Float])])
109+
userFactors: RDD[(Int, Array[Float])],
110+
itemFactors: RDD[(Int, Array[Float])])
111111
extends Model[ALSModel] with ALSParams {
112112

113113
def setPredictionCol(value: String): this.type = set(predictionCol, value)
@@ -151,7 +151,7 @@ class ALSModel[@specialized(Int, Long) UserType, @specialized(Int, Long) ItemTyp
151151

152152
private object ALSModel {
153153
/** Case class to convert factors to SchemaRDDs */
154-
private case class Factor[@specialized(Int, Long) IDType](id: IDType, features: Seq[Float])
154+
private case class Factor(id: Int, features: Seq[Float])
155155
}
156156

157157
/**
@@ -183,8 +183,7 @@ private object ALSModel {
183183
* indicated user
184184
* preferences rather than explicit ratings given to items.
185185
*/
186-
class ALS[@specialized(Int, Long) UserType, @specialized(Int, Long) ItemType]
187-
extends Estimator[ALSModel] with ALSParams {
186+
class ALS extends Estimator[ALSModel] with ALSParams {
188187

189188
import org.apache.spark.ml.recommendation.ALS.Rating
190189

@@ -210,7 +209,7 @@ class ALS[@specialized(Int, Long) UserType, @specialized(Int, Long) ItemType]
210209
setMaxIter(20)
211210
setRegParam(1.0)
212211

213-
override def fit(dataset: SchemaRDD, paramMap: ParamMap): ALSModel[_, _] = {
212+
override def fit(dataset: SchemaRDD, paramMap: ParamMap): ALSModel = {
214213
import dataset.sqlContext._
215214
val map = this.paramMap ++ paramMap
216215
val ratings =

0 commit comments

Comments
 (0)