Skip to content

Commit 5507dd8

Browse files
sarahgerweckpwendell
authored andcommitted
Fix some bugs with spaces in directory name.
Any time you use the directory name (`FWDIR`) it needs to be surrounded in quotes. If you're also using wildcards, you can safely put the quotes around just `$FWDIR`. Author: Sarah Gerweck <[email protected]> Closes apache#1756 from sarahgerweck/folderSpaces and squashes the following commits: 732629d [Sarah Gerweck] Fix some bugs with spaces in directory name.
1 parent 6ba6c3e commit 5507dd8

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

make-distribution.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,22 +168,22 @@ mkdir -p "$DISTDIR/lib"
168168
echo "Spark $VERSION$GITREVSTRING built for Hadoop $SPARK_HADOOP_VERSION" > "$DISTDIR/RELEASE"
169169

170170
# Copy jars
171-
cp $FWDIR/assembly/target/scala*/*assembly*hadoop*.jar "$DISTDIR/lib/"
172-
cp $FWDIR/examples/target/scala*/spark-examples*.jar "$DISTDIR/lib/"
171+
cp "$FWDIR"/assembly/target/scala*/*assembly*hadoop*.jar "$DISTDIR/lib/"
172+
cp "$FWDIR"/examples/target/scala*/spark-examples*.jar "$DISTDIR/lib/"
173173

174174
# Copy example sources (needed for python and SQL)
175175
mkdir -p "$DISTDIR/examples/src/main"
176-
cp -r $FWDIR/examples/src/main "$DISTDIR/examples/src/"
176+
cp -r "$FWDIR"/examples/src/main "$DISTDIR/examples/src/"
177177

178178
if [ "$SPARK_HIVE" == "true" ]; then
179-
cp $FWDIR/lib_managed/jars/datanucleus*.jar "$DISTDIR/lib/"
179+
cp "$FWDIR"/lib_managed/jars/datanucleus*.jar "$DISTDIR/lib/"
180180
fi
181181

182182
# Copy license and ASF files
183183
cp "$FWDIR/LICENSE" "$DISTDIR"
184184
cp "$FWDIR/NOTICE" "$DISTDIR"
185185

186-
if [ -e $FWDIR/CHANGES.txt ]; then
186+
if [ -e "$FWDIR"/CHANGES.txt ]; then
187187
cp "$FWDIR/CHANGES.txt" "$DISTDIR"
188188
fi
189189

0 commit comments

Comments
 (0)