Skip to content

Commit 44ba947

Browse files
author
Alain
committed
Minor][MLLIB] Format toString method in MLLIB
Change to string interpolation way
1 parent bdc402f commit 44ba947

File tree

5 files changed

+7
-8
lines changed

5 files changed

+7
-8
lines changed

mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ class SparseVector(
526526
s" ${values.size} values.")
527527

528528
override def toString: String =
529-
"(%s,%s,%s)".format(size, indices.mkString("[", ",", "]"), values.mkString("[", ",", "]"))
529+
s"($size,${indices.mkString("[", ",", "]")},${values.mkString("[", ",", "]")})"
530530

531531
override def toArray: Array[Double] = {
532532
val data = new Array[Double](size)

mllib/src/main/scala/org/apache/spark/mllib/regression/LabeledPoint.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import org.apache.spark.SparkException
3232
@BeanInfo
3333
case class LabeledPoint(label: Double, features: Vector) {
3434
override def toString: String = {
35-
"(%s,%s)".format(label, features)
35+
s"($label,$features)"
3636
}
3737
}
3838

mllib/src/main/scala/org/apache/spark/mllib/tree/model/InformationGainStats.scala

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ class InformationGainStats(
3939
val rightPredict: Predict) extends Serializable {
4040

4141
override def toString: String = {
42-
"gain = %f, impurity = %f, left impurity = %f, right impurity = %f"
43-
.format(gain, impurity, leftImpurity, rightImpurity)
42+
s"gain = $gain, impurity = $impurity, left impurity = $leftImpurity, right impurity = $rightImpurity"
4443
}
4544

4645
override def equals(o: Any): Boolean = o match {

mllib/src/main/scala/org/apache/spark/mllib/tree/model/Node.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ class Node (
5151
var stats: Option[InformationGainStats]) extends Serializable with Logging {
5252

5353
override def toString: String = {
54-
"id = " + id + ", isLeaf = " + isLeaf + ", predict = " + predict + ", " +
55-
"impurity = " + impurity + ", split = " + split + ", stats = " + stats
54+
s"id = $id, isLeaf = $isLeaf, predict = $predict, impurity = $impurity, " +
55+
s"split = $split, stats = $stats"
5656
}
5757

5858
/**

mllib/src/main/scala/org/apache/spark/mllib/tree/model/Split.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ case class Split(
3939
categories: List[Double]) {
4040

4141
override def toString: String = {
42-
"Feature = " + feature + ", threshold = " + threshold + ", featureType = " + featureType +
43-
", categories = " + categories
42+
s"Feature = $feature, threshold = $threshold, featureType = $featureType, " +
43+
s"categories = $categories"
4444
}
4545
}
4646

0 commit comments

Comments
 (0)