Skip to content

Commit 1426ad8

Browse files
gengliangwangdongjoon-hyun
authored andcommitted
[SPARK-23817][FOLLOWUP][TEST] Add OrcV2QuerySuite
### What changes were proposed in this pull request? Add `OrcV2QuerySuite` which explicitly sets the configuration `USE_V1_SOURCE_LIST` as `""` to use ORC V2 implementation. ### Why are the changes needed? As now file source V2 is disabled by default, the test suite `OrcQuerySuite` is testing V1 implementation as well as the `OrcV1QuerySuite`. We should fix it. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Unit test. Closes apache#27816 from gengliangwang/orcQuerySuite. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent 587266f commit 1426ad8

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ abstract class OrcQueryTest extends OrcTest {
631631
}
632632
}
633633

634-
class OrcQuerySuite extends OrcQueryTest with SharedSparkSession {
634+
abstract class OrcQuerySuite extends OrcQueryTest with SharedSparkSession {
635635
import testImplicits._
636636

637637
test("LZO compression options for writing to an ORC file") {
@@ -722,3 +722,10 @@ class OrcV1QuerySuite extends OrcQuerySuite {
722722
.sparkConf
723723
.set(SQLConf.USE_V1_SOURCE_LIST, "orc")
724724
}
725+
726+
class OrcV2QuerySuite extends OrcQuerySuite {
727+
override protected def sparkConf: SparkConf =
728+
super
729+
.sparkConf
730+
.set(SQLConf.USE_V1_SOURCE_LIST, "")
731+
}

0 commit comments

Comments
 (0)