Skip to content

Commit 0b03fbb

Browse files
committed
code review.
1 parent f2f4348 commit 0b03fbb

File tree

3 files changed

+10
-15
lines changed

3 files changed

+10
-15
lines changed

sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ class InsertIntoHiveTableSuite extends QueryTest with BeforeAndAfter {
228228
s"""
229229
|CREATE TABLE table_with_partition(key int,value string)
230230
|PARTITIONED by (ds string) location '${tmpDir.toURI.toString}'
231-
""".stripMargin)
231+
""".stripMargin)
232232
sql(
233233
"""
234234
|INSERT OVERWRITE TABLE table_with_partition

sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -238,11 +238,8 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter {
238238
}
239239

240240
createQueryTest("modulus",
241-
"""
242-
|SELECT 11 % 10,
243-
| IF((101.1 % 100.0) BETWEEN 1.01 AND 1.11, "true", "false"), (101 / 2) % 10
244-
|FROM src LIMIT 1
245-
""".stripMargin)
241+
"SELECT 11 % 10, IF((101.1 % 100.0) BETWEEN 1.01 AND 1.11, \"true\", \"false\"), " +
242+
"(101 / 2) % 10 FROM src LIMIT 1"))
246243

247244
test("Query expressed in SQL") {
248245
setConf("spark.sql.dialect", "sql")
@@ -314,10 +311,8 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter {
314311
"SELECT * FROM src a JOIN src b ON a.key = b.key")
315312

316313
createQueryTest("small.cartesian",
317-
"""
318-
|SELECT a.key, b.key FROM (SELECT key FROM src WHERE key < 1) a
319-
|JOIN (SELECT key FROM src WHERE key = 2) b
320-
""".stripMargin)
314+
"SELECT a.key, b.key FROM (SELECT key FROM src WHERE key < 1) a JOIN " +
315+
"(SELECT key FROM src WHERE key = 2) b"))
321316

322317
createQueryTest("length.udf",
323318
"SELECT length(\"test\") FROM src LIMIT 1")
@@ -465,17 +460,17 @@ class HiveQuerySuite extends HiveComparisonTest with BeforeAndAfter {
465460
createQueryTest("lateral view3",
466461
"FROM src SELECT key, D.* lateral view explode(array(key+3, key+4)) D as CX")
467462

463+
// scalastyle:off
468464
createQueryTest("lateral view4",
469465
"""
470466
|create table src_lv1 (key string, value string);
471467
|create table src_lv2 (key string, value string);
472468
|
473469
|FROM src
474-
|insert overwrite table src_lv1
475-
| SELECT key, D.* lateral view explode(array(key+3, key+4)) D as CX
476-
|insert overwrite table src_lv2
477-
| SELECT key, D.* lateral view explode(array(key+3, key+4)) D as CX
470+
|insert overwrite table src_lv1 SELECT key, D.* lateral view explode(array(key+3, key+4)) D as CX
471+
|insert overwrite table src_lv2 SELECT key, D.* lateral view explode(array(key+3, key+4)) D as CX
478472
""".stripMargin)
473+
// scalastyle:on
479474

480475
createQueryTest("lateral view5",
481476
"FROM src SELECT explode(array(key+3, key+4))")

sql/hive/src/test/scala/org/apache/spark/sql/hive/parquetSuites.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -890,7 +890,7 @@ abstract class ParquetPartitioningTest extends QueryTest with BeforeAndAfterAll
890890
s"""
891891
|SELECT p, structField.intStructField, structField.stringStructField
892892
|FROM $table WHERE p = 1
893-
""".stripMargin),
893+
""".stripMargin),
894894
(1 to 10).map(i => Row(1, i, f"${i}_string")))
895895
}
896896

0 commit comments

Comments
 (0)