Merge pull request #16 from Coder-Spirit/stabilise

feat!: remove constructor combinator

Author: castarco

README.md

@@ -38,7 +38,6 @@ import { ... } from 'https://deno.land/x/lambda_ioc@[VERSION]/lambda-ioc/deno/in
 ```ts
 import {
   cc2ic, // Stands for "class-constructor to interface-constructor"
-  constructor,
   createContainer,
   func
 } from '@coderspirit/lambda-ioc'
@@ -64,10 +63,8 @@ const container = createContainer()
   .registerValue('someName', 'Timmy')
   // We can register functions
   .register('fn', func(printNameAndAge, 'someName', 'someAge'))
-  // And constructors too
-  .register('Person', constructor(Person, 'someAge', 'someName'))
-  // We can do that directly, without having import `constructor`:
-  .registerConstructor('AnotherPerson', Person, 'someAge', 'someName')
+  // And constructors too:
+  .registerConstructor('Person', Person, 'someAge', 'someName')
   // In case we want to register a "concrete" constructor to provide an
   // abstract interface, we'll have to apply a small hack, using `cc2ic`:
   .registerConstructor('Human', cc2ic<Human>()(Person), 'someAge', 'someName')
@@ -96,14 +93,6 @@ container.resolveGroup('group2') // ~ [3, 4], not necessarily in the same order
 // up to date. This is useful if we want to use the container as a factory for
 // some of your dependencies.
 const resolvedContainer = container.resolve('$')
-
-// If you want to indirectly resolve the container itself, it can be done only
-// with the methods:
-//   - registerConstructor
-//   - registerAsyncConstructor
-// This is because they have "privileged" information about the container's
-// type, while relying on `register` or `registerAsync` plus "combinators" does
-// not allow us to leverage that information.
 ```
 
 It is also possible to register and resolve asynchronous factories and

lambda-ioc/README.md

@@ -38,7 +38,6 @@ import { ... } from 'https://deno.land/x/lambda_ioc@[VERSION]/lambda-ioc/deno/in
 ```ts
 import {
   cc2ic, // Stands for "class-constructor to interface-constructor"
-  constructor,
   createContainer,
   func
 } from '@coderspirit/lambda-ioc'
@@ -64,10 +63,8 @@ const container = createContainer()
   .registerValue('someName', 'Timmy')
   // We can register functions
   .register('fn', func(printNameAndAge, 'someName', 'someAge'))
-  // And constructors too
-  .register('Person', constructor(Person, 'someAge', 'someName'))
-  // We can do that directly, without having import `constructor`:
-  .registerConstructor('AnotherPerson', Person, 'someAge', 'someName')
+  // And constructors too:
+  .registerConstructor('Person', Person, 'someAge', 'someName')
   // In case we want to register a "concrete" constructor to provide an
   // abstract interface, we'll have to apply a small hack, using `cc2ic`:
   .registerConstructor('Human', cc2ic<Human>()(Person), 'someAge', 'someName')
@@ -96,14 +93,6 @@ container.resolveGroup('group2') // ~ [3, 4], not necessarily in the same order
 // up to date. This is useful if we want to use the container as a factory for
 // some of your dependencies.
 const resolvedContainer = container.resolve('$')
-
-// If you want to indirectly resolve the container itself, it can be done only
-// with the methods:
-//   - registerConstructor
-//   - registerAsyncConstructor
-// This is because they have "privileged" information about the container's
-// type, while relying on `register` or `registerAsync` plus "combinators" does
-// not allow us to leverage that information.
 ```
 
 It is also possible to register and resolve asynchronous factories and

lambda-ioc/deno/combinators.ts

@@ -87,32 +87,6 @@ export function func<
   }
 }
 
-/**
- * Given a class constructor, and a list of named dependencies, creates a new
- * dependency factory that will resolve a new instance of the class.
- */
-export function constructor<
-  TParams extends readonly unknown[],
-  TClass,
-  TDependencies extends ParamsToResolverKeys<TParams>,
->(
-  constructor: new (...args: TParams) => Awaited<TClass>,
-  ...args: TDependencies
-): SyncDependencyFactory<TClass, SyncFuncContainer<TParams, TDependencies>> {
-  return (container: SyncFuncContainer<TParams, TDependencies>) => {
-    const resolvedArgs = args.map((arg) =>
-      container.resolve(
-        // This is ugly as hell, but I did not want to apply ts-ignore
-        arg as Parameters<
-          SyncFuncContainer<TParams, TDependencies>['resolve']
-        >[0],
-      ),
-    ) as unknown as TParams
-
-    return new constructor(...resolvedArgs)
-  }
-}
-
 // Class-Constructor to Interface-Constructor
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function cc2ic<I>(): <CC extends new (...args: any[]) => I>(cc: CC) => AsInterfaceCtor<I, CC> {

lambda-ioc/deno/index.ts

@@ -11,7 +11,6 @@ export {
 export {
   asyncSingleton,
   cc2ic,
-  constructor,
   func,
   singleton,
 } from './combinators.ts';

lambda-ioc/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@coderspirit/lambda-ioc",
-  "version": "0.8.0",
+  "version": "1.0.0",
   "main": "./dist/cjs/index.js",
   "module": "./dist/esm/index.js",
   "types": "./dist/cjs/index.d.ts",

lambda-ioc/src/__tests__/constructor.test.ts

@@ -87,32 +87,6 @@ export function func<
   }
 }
 
-/**
- * Given a class constructor, and a list of named dependencies, creates a new
- * dependency factory that will resolve a new instance of the class.
- */
-export function constructor<
-  TParams extends readonly unknown[],
-  TClass,
-  TDependencies extends ParamsToResolverKeys<TParams>,
->(
-  constructor: new (...args: TParams) => Awaited<TClass>,
-  ...args: TDependencies
-): SyncDependencyFactory<TClass, SyncFuncContainer<TParams, TDependencies>> {
-  return (container: SyncFuncContainer<TParams, TDependencies>) => {
-    const resolvedArgs = args.map((arg) =>
-      container.resolve(
-        // This is ugly as hell, but I did not want to apply ts-ignore
-        arg as Parameters<
-          SyncFuncContainer<TParams, TDependencies>['resolve']
-        >[0],
-      ),
-    ) as unknown as TParams
-
-    return new constructor(...resolvedArgs)
-  }
-}
-
 // Class-Constructor to Interface-Constructor
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function cc2ic<I>(): <CC extends new (...args: any[]) => I>(cc: CC) => AsInterfaceCtor<I, CC> {

lambda-ioc/src/combinators.ts

@@ -11,7 +11,6 @@ export {
 export {
   asyncSingleton,
   cc2ic,
-  constructor,
   func,
   singleton,
 } from './combinators'