Use Vec<u8> type for received proofs

Since only the light client know the encoding of the proof, we should
not decode the proof in other places.

Author: Park Juhyung

core/src/ibc/connection_03/manager.rs

@@ -67,8 +67,8 @@ impl<'a> Manager<'a> {
         counterparty_prefix: CommitmentPrefix,
         counterparty_client_identifier: Identifier,
         client_identifier: Identifier,
-        proof_init: CommitmentProof,
-        proof_consensus: CommitmentProof,
+        proof_init: Vec<u8>,
+        proof_consensus: Vec<u8>,
         proof_height: u64,
         consensus_height: u64,
     ) -> Result<(), String> {
@@ -135,13 +135,19 @@ impl<'a> Manager<'a> {
         &mut self,
         connection: &ConnectionEnd,
         proof_height: u64,
-        proof: CommitmentProof,
+        proof: Vec<u8>,
         connection_identifier: Identifier,
         connection_end: &ConnectionEnd,
     ) -> bool {
+        let proof_dec: CommitmentProof = if let Ok(proof) = rlp::decode(&proof) {
+            proof
+        } else {
+            return false
+        };
+
         // check values in the connection_end
         let path = format!("connections/{}", connection_identifier);
-        self.client_verify_membership(proof_height, proof, path, &rlp::encode(connection_end))
+        self.client_verify_membership(proof_height, proof_dec, path, &rlp::encode(connection_end))
     }
 
     fn client_verify_membership(

core/src/ibc/transaction_handler/mod.rs

@@ -18,7 +18,7 @@ mod datagrams;
 
 use self::datagrams::Datagram;
 use crate::ibc;
-use crate::ibc::commitment_23::types::{CommitmentPrefix, CommitmentProof};
+use crate::ibc::commitment_23::types::CommitmentPrefix;
 use ckey::{Address, Public};
 use cstate::{StateResult, TopLevelState};
 use ctypes::errors::RuntimeError;
@@ -80,13 +80,6 @@ pub fn execute(
         } => {
             let mut connection_manager = ibc_connection::Manager::new(&mut context);
 
-            let proof_init_dec: CommitmentProof = rlp::Rlp::new(&proof_init)
-                .as_val()
-                .map_err(|err| RuntimeError::IBC(format!("ConnOpenTry failed to decode proof_init {}", err)))?;
-            let proof_consensus_dec: CommitmentProof = rlp::Rlp::new(&proof_consensus)
-                .as_val()
-                .map_err(|err| RuntimeError::IBC(format!("ConnOpenTry failed to decode consensus_init {}", err)))?;
-
             connection_manager
                 .handle_open_try(
                     desired_identifier,
@@ -96,8 +89,8 @@ pub fn execute(
                     },
                     counterparty_client_identifier,
                     client_identifier,
-                    proof_init_dec,
-                    proof_consensus_dec,
+                    proof_init,
+                    proof_consensus,
                     proof_height,
                     consensus_height,
                 )