Fix a step regression bug in Tendermint::worker::new_blocks

A regression in the step can cause a node double-vote.

Author: foriequal0

core/src/consensus/tendermint/worker.rs

@@ -1437,17 +1437,24 @@ impl Worker {
             }
         };
 
-        if !imported.is_empty() {
-            let mut height_changed = false;
+        if let Some((last, rest)) = imported.split_last() {
+            let (imported, last_proposal_header) = {
+                let header =
+                    c.block_header(&last.clone().into()).expect("ChainNotify is called after the block is imported");
+                let full_header = header.decode();
+                if self.is_proposal(full_header.number(), full_header.hash()) {
+                    (rest, Some(full_header))
+                } else {
+                    (imported.as_slice(), None)
+                }
+            };
+            let height_at_begin = self.height;
             for hash in imported {
                 // New Commit received, skip to next height.
-                let header = c.block_header(&hash.into()).expect("ChainNotify is called after the block is imported");
-
+                let header =
+                    c.block_header(&hash.clone().into()).expect("ChainNotify is called after the block is imported");
                 let full_header = header.decode();
-                if self.is_proposal(full_header.number(), full_header.hash()) {
-                    self.on_imported_proposal(&full_header);
-                } else if self.height < header.number() {
-                    height_changed = true;
+                if self.height < header.number() {
                     cinfo!(ENGINE, "Received a commit: {:?}.", header.number());
                     let prev_block_view = TendermintSealView::new(full_header.seal())
                         .previous_block_view()
@@ -1456,11 +1463,14 @@ impl Worker {
                     self.save_last_confirmed_view(prev_block_view);
                 }
             }
-            if height_changed {
+            if height_at_begin != self.height {
                 self.move_to_step(Step::Propose, false);
-                return
+            }
+            if let Some(last_proposal_header) = last_proposal_header {
+                self.on_imported_proposal(&last_proposal_header);
             }
         }
+
         if !enacted.is_empty() && self.can_move_from_commit_to_propose() {
             let new_height = self.height + 1;
             self.move_to_height(new_height);