Skip to content

Commit 15e3b67

Browse files
Seulgi Kimmergify[bot]
authored andcommitted
Remove the types from tests
Rust compiler can infer those types.
1 parent 3e7368a commit 15e3b67

File tree

10 files changed

+63
-88
lines changed

10 files changed

+63
-88
lines changed

json/src/scheme/account.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2018 Kodebox, Inc.
1+
// Copyright 2018-2019 Kodebox, Inc.
22
// This file is part of CodeChain.
33
//
44
// This program is free software: you can redistribute it and/or modify
@@ -34,11 +34,9 @@ impl Account {
3434

3535
#[cfg(test)]
3636
mod tests {
37-
use primitives::U256;
3837
use serde_json;
3938

4039
use super::Account;
41-
use crate::uint::Uint;
4240

4341
#[test]
4442
fn account_deserialization() {
@@ -48,7 +46,7 @@ mod tests {
4846
}"#;
4947
let deserialized: Account = serde_json::from_str(s).unwrap();
5048
assert!(!deserialized.is_empty());
51-
assert_eq!(deserialized.balance.unwrap(), Uint(U256::from(1)));
52-
assert_eq!(deserialized.seq.unwrap(), Uint(U256::from(0)));
49+
assert_eq!(deserialized.balance, Some(1.into()));
50+
assert_eq!(deserialized.seq, Some(0.into()));
5351
}
5452
}

json/src/scheme/blake_pow.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2018 Kodebox, Inc.
1+
// Copyright 2018-2019 Kodebox, Inc.
22
// This file is part of CodeChain.
33
//
44
// This program is free software: you can redistribute it and/or modify
@@ -33,11 +33,9 @@ pub struct BlakePoW {
3333

3434
#[cfg(test)]
3535
mod tests {
36-
use primitives::U256;
3736
use serde_json;
3837

3938
use super::*;
40-
use crate::uint::Uint;
4139

4240
#[test]
4341
fn blake_pow_deserialization() {
@@ -51,9 +49,9 @@ mod tests {
5149
}"#;
5250

5351
let deserialized: BlakePoW = serde_json::from_str(s).unwrap();
54-
assert_eq!(deserialized.params.block_reward, Some(Uint(U256::from(0x0d))));
55-
assert_eq!(deserialized.params.min_score, Some(Uint(U256::from(0x0002_0000))));
56-
assert_eq!(deserialized.params.block_interval, Some(Uint(U256::from(120))));
57-
assert_eq!(Some(Uint(15.into())), deserialized.params.recommended_confirmation);
52+
assert_eq!(deserialized.params.block_reward, Some(0x0d.into()));
53+
assert_eq!(deserialized.params.min_score, Some(0x0002_0000.into()));
54+
assert_eq!(deserialized.params.block_interval, Some(120.into()));
55+
assert_eq!(deserialized.params.recommended_confirmation, Some(15.into()));
5856
}
5957
}

json/src/scheme/cuckoo.rs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2018 Kodebox, Inc.
1+
// Copyright 2018-2019 Kodebox, Inc.
22
// This file is part of CodeChain.
33
//
44
// This program is free software: you can redistribute it and/or modify
@@ -36,11 +36,9 @@ pub struct Cuckoo {
3636

3737
#[cfg(test)]
3838
mod tests {
39-
use primitives::U256;
4039
use serde_json;
4140

4241
use super::*;
43-
use crate::uint::Uint;
4442

4543
#[test]
4644
fn cuckoo_deserialization() {
@@ -57,12 +55,12 @@ mod tests {
5755
}"#;
5856

5957
let deserialized: Cuckoo = serde_json::from_str(s).unwrap();
60-
assert_eq!(deserialized.params.block_reward, Some(Uint(U256::from(0x0d))));
61-
assert_eq!(deserialized.params.block_interval, Some(Uint(U256::from(120))));
62-
assert_eq!(deserialized.params.min_score, Some(Uint(U256::from(0x0002_0000))));
63-
assert_eq!(deserialized.params.max_vertex, Some(Uint(U256::from(16))));
64-
assert_eq!(deserialized.params.max_edge, Some(Uint(U256::from(8))));
65-
assert_eq!(deserialized.params.cycle_length, Some(Uint(U256::from(6))));
66-
assert_eq!(Some(Uint(6.into())), deserialized.params.recommended_confirmation);
58+
assert_eq!(deserialized.params.block_reward, Some(0x0d.into()));
59+
assert_eq!(deserialized.params.block_interval, Some(120.into()));
60+
assert_eq!(deserialized.params.min_score, Some(0x0002_0000.into()));
61+
assert_eq!(deserialized.params.max_vertex, Some(16.into()));
62+
assert_eq!(deserialized.params.max_edge, Some(8.into()));
63+
assert_eq!(deserialized.params.cycle_length, Some(6.into()));
64+
assert_eq!(deserialized.params.recommended_confirmation, Some(6.into()));
6765
}
6866
}

json/src/scheme/genesis.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,14 +49,13 @@ mod tests {
4949

5050
use ckey::PlatformAddress;
5151

52-
use primitives::{H256 as Core256, H520 as Core520, U256};
52+
use primitives::{H256 as Core256, H520 as Core520};
5353
use serde_json;
5454

5555
use super::super::{Seal, TendermintSeal};
5656
use super::Genesis;
5757
use crate::bytes::Bytes;
5858
use crate::hash::{H256, H520};
59-
use crate::uint::Uint;
6059

6160
#[test]
6261
fn genesis_deserialization() {
@@ -80,15 +79,15 @@ mod tests {
8079
let deserialized: Genesis = serde_json::from_str(s).unwrap();
8180
assert_eq!(deserialized, Genesis {
8281
seal: Seal::Tendermint(TendermintSeal {
83-
prev_view: Uint(U256::from(0x0)),
84-
cur_view: Uint(U256::from(0x0)),
82+
prev_view: 0x0.into(),
83+
cur_view: 0x0.into(),
8584
precommits: vec![
8685
H520(Core520::from("0x0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000")),
8786
]
8887
}),
89-
score: Uint(U256::from(0x0004_0000_0000u64)),
88+
score: 0x0004_0000_0000u64.into(),
9089
author: Some(PlatformAddress::from_str("tccqyqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqhhn9p3").unwrap()),
91-
timestamp: Some(Uint(U256::from(0x07))),
90+
timestamp: Some(0x07.into()),
9291
parent_hash: Some(H256(Core256::from("0x9000000000000000000000000000000000000000000000000000000000000000"))),
9392
transactions_root: None,
9493
state_root: Some(H256(Core256::from("0xd7f8974fb5ac78d9ac099b9ad5018bedc2ce0a72dad1827a1709da30580f0544"))),

json/src/scheme/null_engine.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2018 Kodebox, Inc.
1+
// Copyright 2018-2019 Kodebox, Inc.
22
// This file is part of CodeChain.
33
//
44
// This program is free software: you can redistribute it and/or modify
@@ -32,11 +32,9 @@ pub struct NullEngine {
3232

3333
#[cfg(test)]
3434
mod tests {
35-
use primitives::U256;
3635
use serde_json;
3736

3837
use super::*;
39-
use crate::uint::Uint;
4038

4139
#[test]
4240
fn null_engine_deserialization() {
@@ -47,6 +45,6 @@ mod tests {
4745
}"#;
4846

4947
let deserialized: NullEngine = serde_json::from_str(s).unwrap();
50-
assert_eq!(deserialized.params.block_reward, Some(Uint(U256::from(0x0d))));
48+
assert_eq!(deserialized.params.block_reward, Some(0x0d.into()));
5149
}
5250
}

json/src/scheme/params.rs

Lines changed: 22 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,9 @@ pub struct Params {
6060

6161
#[cfg(test)]
6262
mod tests {
63-
use primitives::U256;
6463
use serde_json;
6564

6665
use super::Params;
67-
use crate::uint::Uint;
6866

6967
#[test]
7068
fn params_deserialization() {
@@ -95,28 +93,28 @@ mod tests {
9593
}"#;
9694

9795
let deserialized: Params = serde_json::from_str(s).unwrap();
98-
assert_eq!(deserialized.max_extra_data_size, Uint(U256::from(0x20)));
99-
assert_eq!(deserialized.max_asset_scheme_metadata_size, Uint(U256::from(0x0400)));
100-
assert_eq!(deserialized.max_transfer_metadata_size, Uint(U256::from(0x0100)));
101-
assert_eq!(deserialized.max_text_content_size, Uint(U256::from(0x0200)));
96+
assert_eq!(deserialized.max_extra_data_size, 0x20.into());
97+
assert_eq!(deserialized.max_asset_scheme_metadata_size, 0x0400.into());
98+
assert_eq!(deserialized.max_transfer_metadata_size, 0x0100.into());
99+
assert_eq!(deserialized.max_text_content_size, 0x0200.into());
102100
assert_eq!(deserialized.network_id, "tc".into());
103-
assert_eq!(deserialized.min_pay_cost, Uint(10.into()));
104-
assert_eq!(deserialized.min_set_regular_key_cost, Uint(11.into()));
105-
assert_eq!(deserialized.min_create_shard_cost, Uint(12.into()));
106-
assert_eq!(deserialized.min_set_shard_owners_cost, Uint(13.into()));
107-
assert_eq!(deserialized.min_set_shard_users_cost, Uint(14.into()));
108-
assert_eq!(deserialized.min_wrap_ccc_cost, Uint(15.into()));
109-
assert_eq!(deserialized.min_custom_cost, Uint(16.into()));
110-
assert_eq!(deserialized.min_store_cost, Uint(17.into()));
111-
assert_eq!(deserialized.min_remove_cost, Uint(18.into()));
112-
assert_eq!(deserialized.min_mint_asset_cost, Uint(19.into()));
113-
assert_eq!(deserialized.min_transfer_asset_cost, Uint(20.into()));
114-
assert_eq!(deserialized.min_change_asset_scheme_cost, Uint(21.into()));
115-
assert_eq!(deserialized.min_compose_asset_cost, Uint(22.into()));
116-
assert_eq!(deserialized.min_decompose_asset_cost, Uint(23.into()));
117-
assert_eq!(deserialized.min_unwrap_ccc_cost, Uint(24.into()));
118-
assert_eq!(deserialized.min_increase_asset_supply_cost, Uint(25.into()));
119-
assert_eq!(deserialized.max_body_size, Uint(4_194_304.into()));
120-
assert_eq!(deserialized.snapshot_period, Uint(16_384.into()));
101+
assert_eq!(deserialized.min_pay_cost, 10.into());
102+
assert_eq!(deserialized.min_set_regular_key_cost, 11.into());
103+
assert_eq!(deserialized.min_create_shard_cost, 12.into());
104+
assert_eq!(deserialized.min_set_shard_owners_cost, 13.into());
105+
assert_eq!(deserialized.min_set_shard_users_cost, 14.into());
106+
assert_eq!(deserialized.min_wrap_ccc_cost, 15.into());
107+
assert_eq!(deserialized.min_custom_cost, 16.into());
108+
assert_eq!(deserialized.min_store_cost, 17.into());
109+
assert_eq!(deserialized.min_remove_cost, 18.into());
110+
assert_eq!(deserialized.min_mint_asset_cost, 19.into());
111+
assert_eq!(deserialized.min_transfer_asset_cost, 20.into());
112+
assert_eq!(deserialized.min_change_asset_scheme_cost, 21.into());
113+
assert_eq!(deserialized.min_compose_asset_cost, 22.into());
114+
assert_eq!(deserialized.min_decompose_asset_cost, 23.into());
115+
assert_eq!(deserialized.min_unwrap_ccc_cost, 24.into());
116+
assert_eq!(deserialized.min_increase_asset_supply_cost, 25.into());
117+
assert_eq!(deserialized.max_body_size, 4_194_304.into());
118+
assert_eq!(deserialized.snapshot_period, 16_384.into());
121119
}
122120
}

json/src/scheme/seal.rs

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2018 Kodebox, Inc.
1+
// Copyright 2018-2019 Kodebox, Inc.
22
// This file is part of CodeChain.
33
//
44
// This program is free software: you can redistribute it and/or modify
@@ -41,13 +41,12 @@ pub enum Seal {
4141

4242
#[cfg(test)]
4343
mod tests {
44-
use primitives::{H520 as Core520, U256};
44+
use primitives::H520 as Core520;
4545
use serde_json;
4646

4747
use super::{Seal, TendermintSeal};
4848
use crate::bytes::Bytes;
4949
use crate::hash::H520;
50-
use crate::uint::Uint;
5150

5251
#[test]
5352
fn seal_deserialization() {
@@ -64,22 +63,16 @@ mod tests {
6463
}]"#;
6564

6665
let deserialized: Vec<Seal> = serde_json::from_str(s).unwrap();
67-
assert_eq!(deserialized.len(), 2);
68-
69-
// [0]
70-
assert_eq!(
71-
deserialized[0],
66+
assert_eq!(deserialized, vec![
7267
Seal::Generic(Bytes::new(vec![
7368
0xe0, 0x11, 0xbb, 0xe8, 0xdb, 0x4e, 0x34, 0x7b, 0x4e, 0x8c, 0x93, 0x7c, 0x1c, 0x83, 0x70, 0xe4, 0xb5,
7469
0xed, 0x33, 0xad, 0xb3, 0xdb, 0x69, 0xcb, 0xdb, 0x7a, 0x38, 0xe1, 0xe5, 0x0b, 0x1b, 0x82, 0xfa,
75-
]))
76-
);
77-
78-
// [1]
79-
assert_eq!(deserialized[1], Seal::Tendermint(TendermintSeal {
80-
prev_view: Uint(U256::from(0x3)),
81-
cur_view: Uint(U256::from(0x4)),
82-
precommits: vec![H520(Core520::from("0x4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004"))]
83-
}));
70+
])),
71+
Seal::Tendermint(TendermintSeal {
72+
prev_view: 0x3.into(),
73+
cur_view: 0x4.into(),
74+
precommits: vec![H520(Core520::from("0x4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004"))]
75+
}),
76+
]);
8477
}
8578
}

json/src/scheme/shard.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2018 Kodebox, Inc.
1+
// Copyright 2018-2019 Kodebox, Inc.
22
// This file is part of CodeChain.
33
//
44
// This program is free software: you can redistribute it and/or modify
@@ -30,7 +30,6 @@ mod tests {
3030
use std::str::FromStr;
3131

3232
use ckey::PlatformAddress;
33-
use primitives::U256;
3433
use serde_json;
3534

3635
use super::*;
@@ -44,7 +43,7 @@ mod tests {
4443
let shard: Shard = serde_json::from_str(s).unwrap();
4544
assert_eq!(
4645
Shard {
47-
seq: Some(Uint(U256::from(0))),
46+
seq: Some(0.into()),
4847
owners: vec![PlatformAddress::from_str("tccq8vapdlstar6ghmqgczp6j2e83njsqq0tsvaxm9u").unwrap()],
4948
users: None,
5049
},
@@ -62,7 +61,7 @@ mod tests {
6261
let shard: Shard = serde_json::from_str(s).unwrap();
6362
assert_eq!(
6463
Shard {
65-
seq: Some(Uint(U256::from(100))),
64+
seq: Some(100.into()),
6665
owners: vec![PlatformAddress::from_str("tccq8vapdlstar6ghmqgczp6j2e83njsqq0tsvaxm9u").unwrap()],
6766
users: Some(vec![PlatformAddress::from_str("tccq8txq9uafdg8y2de9m2tdkhsfsj3m9nluq94hyan").unwrap()]),
6867
},

json/src/scheme/simple_poa.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2018 Kodebox, Inc.
1+
// Copyright 2018-2019 Kodebox, Inc.
22
// This file is part of CodeChain.
33
//
44
// This program is free software: you can redistribute it and/or modify
@@ -39,11 +39,9 @@ mod tests {
3939
use std::str::FromStr;
4040

4141
use ckey::Public;
42-
use primitives::U256;
4342
use serde_json;
4443

4544
use super::SimplePoA;
46-
use crate::uint::Uint;
4745

4846
#[test]
4947
fn basic_authority_deserialization() {
@@ -58,6 +56,6 @@ mod tests {
5856

5957
let vs = vec![Public::from_str("2a8a69439f2396c9a328289fdc3905d9736da9e14eb1a282cfd2c036cc21a17a5d05595160b7924e5ecf3f2628b440e601f3a531e92fa81571a70e6c695b2d08").unwrap()];
6058
assert_eq!(deserialized.params.validators, vs);
61-
assert_eq!(deserialized.params.block_reward, Some(Uint(U256::from(0x0d))));
59+
assert_eq!(deserialized.params.block_reward, Some(0x0d.into()));
6260
}
6361
}

json/src/scheme/solo.rs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,9 @@ pub struct Solo {
4545

4646
#[cfg(test)]
4747
mod tests {
48-
use std::collections::HashMap;
49-
50-
use primitives::U256;
5148
use serde_json;
5249

5350
use super::Solo;
54-
use crate::uint::Uint;
5551

5652
#[test]
5753
fn basic_authority_deserialization() {
@@ -64,8 +60,8 @@ mod tests {
6460
}"#;
6561

6662
let deserialized: Solo = serde_json::from_str(s).unwrap();
67-
assert_eq!(deserialized.params.block_reward, Some(Uint(U256::from(0x0d))));
68-
assert_eq!(deserialized.params.action_handlers.hit, Some(HashMap::new()));
69-
assert_eq!(deserialized.params.action_handlers.genesis_stakes, Some(HashMap::new()));
63+
assert_eq!(deserialized.params.block_reward, Some(0x0d.into()));
64+
assert_eq!(deserialized.params.action_handlers.hit, Some(Default::default()));
65+
assert_eq!(deserialized.params.action_handlers.genesis_stakes, Some(Default::default()));
7066
}
7167
}

0 commit comments

Comments
 (0)