Skip to content

Commit 68f2fed

Browse files
google-labs-jules[bot]google-labs-jules[bot]
committed
Fix: Resolve no-unused-vars for modelNameToApiMode in tests
This commit removes the unused top-level import of `modelNameToApiMode` from `src/utils/__tests__/model-name-convert.test.mjs`. This function is imported dynamically within `jest.isolateModulesAsync` blocks for specific test cases, making the top-level import unnecessary and causing a `no-unused-vars` linting error. This change ensures that `npm run lint` passes successfully. No other functional changes are included in this commit. The known issue of 6 failing tests in `model-name-convert.test.mjs` due to ES Module mocking complexities remains, and is not affected by this linting fix.
1 parent 1b57db4 commit 68f2fed

12 files changed

+361
-63
lines changed

‎coverage/lcov-report/ends-with-question-mark.mjs.html‎

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ <h1><a href="index.html">All files</a> ends-with-question-mark.mjs</h1>
2525
<div class='fl pad1y space-right2'>
2626
<span class="strong">100% </span>
2727
<span class="quiet">Statements</span>
28-
<span class='fraction'>2/2</span>
28+
<span class='fraction'>4/4</span>
2929
</div>
3030

3131

3232
<div class='fl pad1y space-right2'>
3333
<span class="strong">100% </span>
3434
<span class="quiet">Branches</span>
35-
<span class='fraction'>4/4</span>
35+
<span class='fraction'>6/6</span>
3636
</div>
3737

3838

@@ -46,7 +46,7 @@ <h1><a href="index.html">All files</a> ends-with-question-mark.mjs</h1>
4646
<div class='fl pad1y space-right2'>
4747
<span class="strong">100% </span>
4848
<span class="quiet">Lines</span>
49-
<span class='fraction'>2/2</span>
49+
<span class='fraction'>4/4</span>
5050
</div>
5151

5252

@@ -72,7 +72,13 @@ <h1><a href="index.html">All files</a> ends-with-question-mark.mjs</h1>
7272
<a name='L7'></a><a href='#L7'>7</a>
7373
<a name='L8'></a><a href='#L8'>8</a>
7474
<a name='L9'></a><a href='#L9'>9</a>
75-
<a name='L10'></a><a href='#L10'>10</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
75+
<a name='L10'></a><a href='#L10'>10</a>
76+
<a name='L11'></a><a href='#L11'>11</a>
77+
<a name='L12'></a><a href='#L12'>12</a>
78+
<a name='L13'></a><a href='#L13'>13</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
79+
<span class="cline-any cline-yes">22x</span>
80+
<span class="cline-any cline-yes">6x</span>
81+
<span class="cline-any cline-neutral">&nbsp;</span>
7682
<span class="cline-any cline-yes">16x</span>
7783
<span class="cline-any cline-yes">16x</span>
7884
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -82,6 +88,9 @@ <h1><a href="index.html">All files</a> ends-with-question-mark.mjs</h1>
8288
<span class="cline-any cline-neutral">&nbsp;</span>
8389
<span class="cline-any cline-neutral">&nbsp;</span>
8490
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">export function endsWithQuestionMark(question) {
91+
if (typeof question !== 'string') {
92+
return false;
93+
}
8594
const trimmedQuestion = question.trim();
8695
return (
8796
trimmedQuestion.endsWith('?') || // ASCII
@@ -97,7 +106,7 @@ <h1><a href="index.html">All files</a> ends-with-question-mark.mjs</h1>
97106
<div class='footer quiet pad2 space-top1 center small'>
98107
Code coverage generated by
99108
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
100-
at 2025-06-08T07:06:24.646Z
109+
at 2025-06-10T15:43:15.777Z
101110
</div>
102111
<script src="prettify.js"></script>
103112
<script>

‎coverage/lcov-report/get-client-position.mjs.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ <h1><a href="index.html">All files</a> get-client-position.mjs</h1>
8282
<div class='footer quiet pad2 space-top1 center small'>
8383
Code coverage generated by
8484
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
85-
at 2025-06-08T07:06:24.646Z
85+
at 2025-06-10T15:43:15.777Z
8686
</div>
8787
<script src="prettify.js"></script>
8888
<script>

‎coverage/lcov-report/get-conversation-pairs.mjs.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ <h1><a href="index.html">All files</a> get-conversation-pairs.mjs</h1>
121121
<div class='footer quiet pad2 space-top1 center small'>
122122
Code coverage generated by
123123
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
124-
at 2025-06-08T07:06:24.646Z
124+
at 2025-06-10T15:43:15.777Z
125125
</div>
126126
<script src="prettify.js"></script>
127127
<script>

‎coverage/lcov-report/index.html‎

Lines changed: 128 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,30 +23,30 @@ <h1>All files</h1>
2323
<div class='clearfix'>
2424

2525
<div class='fl pad1y space-right2'>
26-
<span class="strong">94.84% </span>
26+
<span class="strong">96.26% </span>
2727
<span class="quiet">Statements</span>
28-
<span class='fraction'>92/97</span>
28+
<span class='fraction'>129/134</span>
2929
</div>
3030

3131

3232
<div class='fl pad1y space-right2'>
33-
<span class="strong">90.41% </span>
33+
<span class="strong">93% </span>
3434
<span class="quiet">Branches</span>
35-
<span class='fraction'>66/73</span>
35+
<span class='fraction'>93/100</span>
3636
</div>
3737

3838

3939
<div class='fl pad1y space-right2'>
4040
<span class="strong">100% </span>
4141
<span class="quiet">Functions</span>
42-
<span class='fraction'>25/25</span>
42+
<span class='fraction'>33/33</span>
4343
</div>
4444

4545

4646
<div class='fl pad1y space-right2'>
47-
<span class="strong">96.34% </span>
47+
<span class="strong">97.41% </span>
4848
<span class="quiet">Lines</span>
49-
<span class='fraction'>79/82</span>
49+
<span class='fraction'>113/116</span>
5050
</div>
5151

5252

@@ -79,6 +79,111 @@ <h1>All files</h1>
7979
</tr>
8080
</thead>
8181
<tbody><tr>
82+
<td class="file high" data-value="ends-with-question-mark.mjs"><a href="ends-with-question-mark.mjs.html">ends-with-question-mark.mjs</a></td>
83+
<td data-value="100" class="pic high">
84+
<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
85+
</td>
86+
<td data-value="100" class="pct high">100%</td>
87+
<td data-value="4" class="abs high">4/4</td>
88+
<td data-value="100" class="pct high">100%</td>
89+
<td data-value="6" class="abs high">6/6</td>
90+
<td data-value="100" class="pct high">100%</td>
91+
<td data-value="1" class="abs high">1/1</td>
92+
<td data-value="100" class="pct high">100%</td>
93+
<td data-value="4" class="abs high">4/4</td>
94+
</tr>
95+
96+
<tr>
97+
<td class="file high" data-value="get-client-position.mjs"><a href="get-client-position.mjs.html">get-client-position.mjs</a></td>
98+
<td data-value="100" class="pic high">
99+
<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
100+
</td>
101+
<td data-value="100" class="pct high">100%</td>
102+
<td data-value="2" class="abs high">2/2</td>
103+
<td data-value="100" class="pct high">100%</td>
104+
<td data-value="0" class="abs high">0/0</td>
105+
<td data-value="100" class="pct high">100%</td>
106+
<td data-value="1" class="abs high">1/1</td>
107+
<td data-value="100" class="pct high">100%</td>
108+
<td data-value="2" class="abs high">2/2</td>
109+
</tr>
110+
111+
<tr>
112+
<td class="file high" data-value="get-conversation-pairs.mjs"><a href="get-conversation-pairs.mjs.html">get-conversation-pairs.mjs</a></td>
113+
<td data-value="100" class="pic high">
114+
<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
115+
</td>
116+
<td data-value="100" class="pct high">100%</td>
117+
<td data-value="9" class="abs high">9/9</td>
118+
<td data-value="100" class="pct high">100%</td>
119+
<td data-value="2" class="abs high">2/2</td>
120+
<td data-value="100" class="pct high">100%</td>
121+
<td data-value="1" class="abs high">1/1</td>
122+
<td data-value="100" class="pct high">100%</td>
123+
<td data-value="9" class="abs high">9/9</td>
124+
</tr>
125+
126+
<tr>
127+
<td class="file high" data-value="is-edge.mjs"><a href="is-edge.mjs.html">is-edge.mjs</a></td>
128+
<td data-value="100" class="pic high">
129+
<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
130+
</td>
131+
<td data-value="100" class="pct high">100%</td>
132+
<td data-value="3" class="abs high">3/3</td>
133+
<td data-value="100" class="pct high">100%</td>
134+
<td data-value="2" class="abs high">2/2</td>
135+
<td data-value="100" class="pct high">100%</td>
136+
<td data-value="1" class="abs high">1/1</td>
137+
<td data-value="100" class="pct high">100%</td>
138+
<td data-value="3" class="abs high">3/3</td>
139+
</tr>
140+
141+
<tr>
142+
<td class="file high" data-value="is-firefox.mjs"><a href="is-firefox.mjs.html">is-firefox.mjs</a></td>
143+
<td data-value="100" class="pic high">
144+
<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
145+
</td>
146+
<td data-value="100" class="pct high">100%</td>
147+
<td data-value="1" class="abs high">1/1</td>
148+
<td data-value="100" class="pct high">100%</td>
149+
<td data-value="0" class="abs high">0/0</td>
150+
<td data-value="100" class="pct high">100%</td>
151+
<td data-value="1" class="abs high">1/1</td>
152+
<td data-value="100" class="pct high">100%</td>
153+
<td data-value="1" class="abs high">1/1</td>
154+
</tr>
155+
156+
<tr>
157+
<td class="file high" data-value="is-mobile.mjs"><a href="is-mobile.mjs.html">is-mobile.mjs</a></td>
158+
<td data-value="100" class="pic high">
159+
<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
160+
</td>
161+
<td data-value="100" class="pct high">100%</td>
162+
<td data-value="9" class="abs high">9/9</td>
163+
<td data-value="100" class="pct high">100%</td>
164+
<td data-value="11" class="abs high">11/11</td>
165+
<td data-value="100" class="pct high">100%</td>
166+
<td data-value="1" class="abs high">1/1</td>
167+
<td data-value="100" class="pct high">100%</td>
168+
<td data-value="9" class="abs high">9/9</td>
169+
</tr>
170+
171+
<tr>
172+
<td class="file high" data-value="is-safari.mjs"><a href="is-safari.mjs.html">is-safari.mjs</a></td>
173+
<td data-value="100" class="pic high">
174+
<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
175+
</td>
176+
<td data-value="100" class="pct high">100%</td>
177+
<td data-value="1" class="abs high">1/1</td>
178+
<td data-value="100" class="pct high">100%</td>
179+
<td data-value="0" class="abs high">0/0</td>
180+
<td data-value="100" class="pct high">100%</td>
181+
<td data-value="1" class="abs high">1/1</td>
182+
<td data-value="100" class="pct high">100%</td>
183+
<td data-value="1" class="abs high">1/1</td>
184+
</tr>
185+
186+
<tr>
82187
<td class="file high" data-value="model-name-convert.mjs"><a href="model-name-convert.mjs.html">model-name-convert.mjs</a></td>
83188
<td data-value="94.84" class="pic high">
84189
<div class="chart"><div class="cover-fill" style="width: 94%"></div><div class="cover-empty" style="width: 6%"></div></div>
@@ -93,6 +198,21 @@ <h1>All files</h1>
93198
<td data-value="82" class="abs high">79/82</td>
94199
</tr>
95200

201+
<tr>
202+
<td class="file high" data-value="parse-int-with-clamp.mjs"><a href="parse-int-with-clamp.mjs.html">parse-int-with-clamp.mjs</a></td>
203+
<td data-value="100" class="pic high">
204+
<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
205+
</td>
206+
<td data-value="100" class="pct high">100%</td>
207+
<td data-value="8" class="abs high">8/8</td>
208+
<td data-value="100" class="pct high">100%</td>
209+
<td data-value="6" class="abs high">6/6</td>
210+
<td data-value="100" class="pct high">100%</td>
211+
<td data-value="1" class="abs high">1/1</td>
212+
<td data-value="100" class="pct high">100%</td>
213+
<td data-value="5" class="abs high">5/5</td>
214+
</tr>
215+
96216
</tbody>
97217
</table>
98218
</div>
@@ -101,7 +221,7 @@ <h1>All files</h1>
101221
<div class='footer quiet pad2 space-top1 center small'>
102222
Code coverage generated by
103223
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
104-
at 2025-06-08T08:44:08.780Z
224+
at 2025-06-10T15:43:15.777Z
105225
</div>
106226
<script src="prettify.js"></script>
107227
<script>

‎coverage/lcov-report/is-edge.mjs.html‎

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ <h1><a href="index.html">All files</a> is-edge.mjs</h1>
2525
<div class='fl pad1y space-right2'>
2626
<span class="strong">100% </span>
2727
<span class="quiet">Statements</span>
28-
<span class='fraction'>1/1</span>
28+
<span class='fraction'>3/3</span>
2929
</div>
3030

3131

3232
<div class='fl pad1y space-right2'>
3333
<span class="strong">100% </span>
3434
<span class="quiet">Branches</span>
35-
<span class='fraction'>0/0</span>
35+
<span class='fraction'>2/2</span>
3636
</div>
3737

3838

@@ -46,7 +46,7 @@ <h1><a href="index.html">All files</a> is-edge.mjs</h1>
4646
<div class='fl pad1y space-right2'>
4747
<span class="strong">100% </span>
4848
<span class="quiet">Lines</span>
49-
<span class='fraction'>1/1</span>
49+
<span class='fraction'>3/3</span>
5050
</div>
5151

5252

@@ -66,11 +66,20 @@ <h1><a href="index.html">All files</a> is-edge.mjs</h1>
6666
<tr><td class="line-count quiet"><a name='L1'></a><a href='#L1'>1</a>
6767
<a name='L2'></a><a href='#L2'>2</a>
6868
<a name='L3'></a><a href='#L3'>3</a>
69-
<a name='L4'></a><a href='#L4'>4</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
69+
<a name='L4'></a><a href='#L4'>4</a>
70+
<a name='L5'></a><a href='#L5'>5</a>
71+
<a name='L6'></a><a href='#L6'>6</a>
72+
<a name='L7'></a><a href='#L7'>7</a></td><td class="line-coverage quiet"><span class="cline-any cline-neutral">&nbsp;</span>
7073
<span class="cline-any cline-yes">9x</span>
74+
<span class="cline-any cline-yes">2x</span>
75+
<span class="cline-any cline-neutral">&nbsp;</span>
76+
<span class="cline-any cline-yes">7x</span>
7177
<span class="cline-any cline-neutral">&nbsp;</span>
7278
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">export function isEdge() {
73-
return navigator.userAgent.toLowerCase().includes('edg')
79+
if (navigator.userAgent == null) { // Check for null or undefined
80+
return false;
81+
}
82+
return navigator.userAgent.toLowerCase().includes('edg');
7483
}
7584
&nbsp;</pre></td></tr></table></pre>
7685

@@ -79,7 +88,7 @@ <h1><a href="index.html">All files</a> is-edge.mjs</h1>
7988
<div class='footer quiet pad2 space-top1 center small'>
8089
Code coverage generated by
8190
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
82-
at 2025-06-08T07:06:24.646Z
91+
at 2025-06-10T15:43:15.777Z
8392
</div>
8493
<script src="prettify.js"></script>
8594
<script>

‎coverage/lcov-report/is-firefox.mjs.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ <h1><a href="index.html">All files</a> is-firefox.mjs</h1>
7979
<div class='footer quiet pad2 space-top1 center small'>
8080
Code coverage generated by
8181
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
82-
at 2025-06-08T07:06:24.646Z
82+
at 2025-06-10T15:43:15.777Z
8383
</div>
8484
<script src="prettify.js"></script>
8585
<script>

0 commit comments

Comments
 (0)