fatal error in producing log messages

[mamoll]

I get this error with pygccxml 1.6.0:

  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/pygccxml/declarations/class_declaration.py", line 603, in find_noncopyable_vars
    message +
UnboundLocalError: local variable 'message' referenced before assignment

I am not sure what message should be initialized to in line 603 of declarations/class_declaration.py.

There also non-fatal errors in the logger.debug(...) calls in lines 589-597. These can be fixed by putting parentheses around message + " - array" (analogous for the other cases) to force self.decl_string to match %s in message.

[iMichka]

Okay, seems my pep8 cleaning up of the code broke it. And of course I did not see it because this part of the code is not covered by the tests: https://coveralls.io/files/247754441#L585

The fix is easy, I think message is just the basic same message which is used everywhere in this method. I'll write also a test to cover this part of the code. I'll need a day or two, I'm a the Europython this week.

Once it's fixed I'll release a hot fix version 1.6.1. Thanks for the reporting :)

[iMichka]

I pushed a fix for this: 67a9313

I slightly increased the code coverage on this part of the code but it needs some more polishing, I need to understand all the C++ syntax cases that would make a class non-copyable, to write more tests.

Could you test the fix with the v1.6.1 hotfix branch I created ?

[mamoll]

The errors that I thought would be non-fatal are fatal after all. Now I get errors like this:

  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/pygccxml/declarations/class_declaration.py", line 601, in find_noncopyable_vars
    logger.debug(message + " - class" % self.decl_string)
TypeError: not all arguments converted during string formatting

Changing that line (and others like it) to this should fix it:

logger.debug((message + " - class") % self.decl_string)

[mamoll]

I am using python3.4, BTW.

[iMichka]

Yes I forgot to fix this line, and the following one too. I just made a new patch.

Do you have an example of C++ code which would trigger this part of the code ?

[mamoll]

This class seems to trigger that part of the code:
http://ompl.kavrakilab.org/classompl_1_1base_1_1PrecomputedStateSampler.html

[iMichka]

I'll look into this and I'll write a small dummy class to have the code covered. Thanks.

Does it work now with the new patch ?

[mamoll]

Everything seems to work with the latest patch. Thanks.

[iMichka]

I merged in the patches and tagged a new v.1.6.1
I'll upload it to pipy today.