Don't keep editing if new type is not primitive

CarlosNZ · CarlosNZ · commit 4813e1ca7c3b · 2025-07-19T02:34:27.000+12:00
diff --git a/README.md b/README.md
@@ -1238,6 +1238,7 @@ This component is heavily inspired by [react-json-view](https://github.com/mac-s
 
 ## Changelog
 
+- **1.28.2**: When switching data type, only keep editing if new type is primitive ([#216](https://github.com/CarlosNZ/json-edit-react/issues/216))
 - **1.28.1**: Fix left padding of root node when value is primitive ([#214](https://github.com/CarlosNZ/json-edit-react/issues/214))
 - **1.28.0**:
   - (Optional) tooltips for icons ([#211](https://github.com/CarlosNZ/json-edit-react/pull/211))
diff --git a/src/ValueNodeWrapper.tsx b/src/ValueNodeWrapper.tsx
@@ -200,6 +200,7 @@ export const ValueNodeWrapper: React.FC<ValueNodeProps> = (props) => {
       // that won't match the custom node condition any more
       customNodeData?.CustomNode ? translate('DEFAULT_STRING', nodeData) : undefined
     )
+    if (!['string', 'number', 'boolean'].includes(type)) setCurrentlyEditingElement(null)
     onEdit(newValue, path).then((error) => {
       if (error) {
         onError({ code: 'UPDATE_ERROR', message: error }, newValue as JsonData)

Original file line number	Diff line number	Diff line change
`@@ -200,6 +200,7 @@ export const ValueNodeWrapper: React.FC<ValueNodeProps> = (props) => {`
`200`	`200`	`// that won't match the custom node condition any more`
`201`	`201`	`customNodeData?.CustomNode ? translate('DEFAULT_STRING', nodeData) : undefined`
`202`	`202`	`)`
	`203`	`+ if (!['string', 'number', 'boolean'].includes(type)) setCurrentlyEditingElement(null)`
`203`	`204`	`onEdit(newValue, path).then((error) => {`
`204`	`205`	`if (error) {`
`205`	`206`	`onError({ code: 'UPDATE_ERROR', message: error }, newValue as JsonData)`