Fix types for name in /tracing/transactions.ts

Author: Jack Englund

packages/tracing/src/transaction.ts

@@ -12,7 +12,7 @@ import { Span as SpanClass, SpanRecorder } from './span';
 
 /** JSDoc */
 export class Transaction extends SpanClass implements TransactionInterface {
-  public name: string;
+  public name: string | Symbol;
 
   public metadata: TransactionMetadata;
 
@@ -51,7 +51,7 @@ export class Transaction extends SpanClass implements TransactionInterface {
   /**
    * JSDoc
    */
-  public setName(name: string): void {
+  public setName(name: string | Symbol): void {
     this.name = name;
   }
 
@@ -142,7 +142,7 @@ export class Transaction extends SpanClass implements TransactionInterface {
       transaction.measurements = this._measurements;
     }
 
-    logger.log(`[Tracing] Finishing ${this.op} transaction: ${this.name}.`);
+    logger.log(`[Tracing] Finishing ${this.op} transaction: ${this.name.toString()}.`);
 
     return this._hub.captureEvent(transaction);
   }

packages/types/src/event.ts

@@ -28,7 +28,7 @@ export interface Event {
   environment?: string;
   sdk?: SdkInfo;
   request?: Request;
-  transaction?: string;
+  transaction?: string | Symbol;
   modules?: { [key: string]: string };
   fingerprint?: string[];
   exception?: {
@@ -37,7 +37,7 @@ export interface Event {
   stacktrace?: Stacktrace;
   breadcrumbs?: Breadcrumb[];
   contexts?: Contexts;
-  tags?: { [key: string]: Primitive };
+  tags?: { [key: string]: Primitive | Symbol };
   extra?: Extras;
   user?: User;
   type?: EventType;

packages/types/src/transaction.ts

@@ -8,7 +8,7 @@ export interface TransactionContext extends SpanContext {
   /**
    * Human-readable identifier for the transaction
    */
-  name: string;
+  name: string | Symbol;
 
   /**
    * If true, sets the end timestamp of the transaction to the highest timestamp of child spans, trimming
@@ -56,7 +56,7 @@ export interface Transaction extends TransactionContext, Span {
   /**
    * @inheritDoc
    */
-  tags: { [key: string]: Primitive };
+  tags: { [key: string]: Primitive | Symbol };
 
   /**
    * @inheritDoc
@@ -71,7 +71,7 @@ export interface Transaction extends TransactionContext, Span {
   /**
    * Set the name of the transaction
    */
-  setName(name: string): void;
+  setName(name: string | Symbol): void;
 
   /** Returns the current transaction properties as a `TransactionContext` */
   toContext(): TransactionContext;