Fix bug of FILES command #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Owner
|
Will not merge: The only necessary change is to print the output. The extra function is not needed, as the "files" command is just a file listing. you will never want to (nor should you) output the list of files to EEPROM, etc. It should just be a Serial.print( entry.name() );. Also, the last version of putchar( c ) is completely incorrect. putchar outputs a single character, and you're passing it a pointer to a string. |
Delete outstring function, FILES command use Serial.print().
Author
|
I'm delete the unneeded function and the line changed to Serial.println( entry.name() );. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add outstring function and print filenames with outstring.