Skip to content

Commit f740c6d

Browse files
authored
Update lint_vba.yml (#47)
Fixed bugs and added Linting
1 parent 211d8cf commit f740c6d

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

.github/workflows/lint_vba.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
name: Test and Static Analysis
1212
runs-on: ubuntu-latest
1313
strategy:
14+
fail-fast: false
1415
matrix:
1516
python-version: ["3.11"]
1617

@@ -23,13 +24,8 @@ jobs:
2324
- name: Install dependencies
2425
run: |
2526
python -m pip install antlr4-tools
26-
wget https://raw.githubusercontent.com/antlr/grammars-v4/master/vba/vba.g4
27+
wget https://raw.githubusercontent.com/Beakerboy/VBA_Tokenizer/ANTLR/VbaLint
28+
chmod +x VbaLint
2729
- name: Lint with antlr
2830
run: |
29-
antlr4-parse vba.g4 startRule src/ClassModules/*.cls
30-
antlr4-parse vba.g4 startRule src/Modules/*.bas
31-
- name: Lint tests with antlr
32-
run: |
33-
antlr4-parse vba.g4 startRule testing/ClassModules/*.cls
34-
antlr4-parse vba.g4 startRule testing/Modules/*.bas
35-
31+
./VbaLint

src/ClassModules/SQLRecordset.cls

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,6 @@ Public Function iSQLRecordset_GetRows(num As Integer)
3939
iSQLRecordset_GetRows = orst.GetRows(num)
4040
End Function
4141

42-
Public Property iSQLRecordset_EOF()
42+
Property Get iSQLRecordset_EOF()
4343
iSQLRecordset_EOF = orst.EOF
44-
End Function
44+
End Property

0 commit comments

Comments
 (0)