Skip to content

Commit d6c2e41

Browse files
populate only when telemetry is enabled
1 parent e9efb51 commit d6c2e41

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/AzureAppConfigurationImpl.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { IKeyValueAdapter } from "./IKeyValueAdapter";
99
import { JsonKeyValueAdapter } from "./JsonKeyValueAdapter";
1010
import { DEFAULT_REFRESH_INTERVAL_IN_MS, MIN_REFRESH_INTERVAL_IN_MS } from "./RefreshOptions";
1111
import { Disposable } from "./common/disposable";
12-
import { FEATURE_FLAGS_KEY_NAME, FEATURE_MANAGEMENT_KEY_NAME, TELEMETRY_KEY_NAME, METADATA_KEY_NAME, ETAG_KEY_NAME, FEATURE_FLAG_ID_KEY_NAME, FEATURE_FLAG_REFERENCE_KEY_NAME } from "./featureManagement/constants";
12+
import { FEATURE_FLAGS_KEY_NAME, FEATURE_MANAGEMENT_KEY_NAME, TELEMETRY_KEY_NAME, ENABLED_KEY_NAME, METADATA_KEY_NAME, ETAG_KEY_NAME, FEATURE_FLAG_ID_KEY_NAME, FEATURE_FLAG_REFERENCE_KEY_NAME } from "./featureManagement/constants";
1313
import { AzureKeyVaultKeyValueAdapter } from "./keyvault/AzureKeyVaultKeyValueAdapter";
1414
import { RefreshTimer } from "./refresh/RefreshTimer";
1515
import { getConfigurationSettingWithTrace, listConfigurationSettingsWithTrace, requestTracingEnabled } from "./requestTracing/utils";
@@ -545,7 +545,7 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
545545
}
546546
const featureFlag = JSON.parse(rawFlag);
547547

548-
if (featureFlag[TELEMETRY_KEY_NAME]) {
548+
if (featureFlag[TELEMETRY_KEY_NAME] && featureFlag[TELEMETRY_KEY_NAME][ENABLED_KEY_NAME] === true) {
549549
const metadata = featureFlag[TELEMETRY_KEY_NAME][METADATA_KEY_NAME];
550550
featureFlag[TELEMETRY_KEY_NAME][METADATA_KEY_NAME] = {
551551
[ETAG_KEY_NAME]: setting.etag,
@@ -657,4 +657,4 @@ function getValidFeatureFlagSelectors(selectors?: SettingSelector[]): SettingSel
657657
} else {
658658
return getValidSelectors(selectors);
659659
}
660-
}
660+
}

src/featureManagement/constants.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
export const FEATURE_MANAGEMENT_KEY_NAME = "feature_management";
55
export const FEATURE_FLAGS_KEY_NAME = "feature_flags";
66
export const TELEMETRY_KEY_NAME = "telemetry";
7+
export const ENABLED_KEY_NAME = "enabled";
78
export const METADATA_KEY_NAME = "metadata";
89
export const ETAG_KEY_NAME = "Etag";
910
export const FEATURE_FLAG_ID_KEY_NAME = "FeatureFlagId";
10-
export const FEATURE_FLAG_REFERENCE_KEY_NAME = "FeatureFlagReference";
11+
export const FEATURE_FLAG_REFERENCE_KEY_NAME = "FeatureFlagReference";

0 commit comments

Comments
 (0)