parse feature flag directly

Author: Eskibear

src/AzureAppConfigurationImpl.ts

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
-import { AppConfigurationClient, ConfigurationSetting, ConfigurationSettingId, FeatureFlagValue, GetConfigurationSettingOptions, GetConfigurationSettingResponse, ListConfigurationSettingsOptions, featureFlagPrefix, isFeatureFlag, parseFeatureFlag } from "@azure/app-configuration";
+import { AppConfigurationClient, ConfigurationSetting, ConfigurationSettingId, GetConfigurationSettingOptions, GetConfigurationSettingResponse, ListConfigurationSettingsOptions, featureFlagPrefix, isFeatureFlag } from "@azure/app-configuration";
 import { RestError } from "@azure/core-rest-pipeline";
 import { AzureAppConfiguration, ConfigurationObjectConstructionOptions } from "./AzureAppConfiguration";
 import { AzureAppConfigurationOptions } from "./AzureAppConfigurationOptions";
@@ -239,7 +239,7 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
     }
 
     async #loadFeatureFlags() {
-        const featureFlags: FeatureFlagValue[] = [];
+        const featureFlags: unknown[] = [];
         const featureFlagSelectors = getValidFeatureFlagSelectors(this.#options?.featureFlagOptions?.selectors);
         for (const selector of featureFlagSelectors) {
             const listOptions: ListConfigurationSettingsOptions = {
@@ -258,8 +258,8 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
             );
             for await (const setting of settings) {
                 if (isFeatureFlag(setting)) {
-                    const flag = parseFeatureFlag(setting);
-                    featureFlags.push(flag.value)
+                    const flag = JSON.parse(setting.value);
+                    featureFlags.push(flag)
                 }
             }
         }

test/featureFlag.test.ts

@@ -8,9 +8,48 @@ import { createMockedConnectionString, createMockedFeatureFlag, createMockedKeyV
 chai.use(chaiAsPromised);
 const expect = chai.expect;
 
+const sampleVariantValue = JSON.stringify({
+	"id": "variant",
+	"description": "",
+	"enabled": true,
+	"variants": [
+		{
+			"name": "Off",
+			"configuration_value": false
+		},
+		{
+			"name": "On",
+			"configuration_value": true
+		}
+	],
+	"allocation": {
+		"percentile": [
+			{
+				"variant": "Off",
+				"from": 0,
+				"to": 40
+			},
+			{
+				"variant": "On",
+				"from": 49,
+				"to": 100
+			}
+		],
+		"default_when_enabled": "Off",
+		"default_when_disabled": "Off"
+	},
+	"telemetry": {
+		"enabled": false
+	}
+});
+
 const mockedKVs = [{
     key: "app.settings.fontColor",
     value: "red",
+}, {
+    key: ".appconfig.featureflag/variant",
+    value: sampleVariantValue,
+    contentType: "application/vnd.microsoft.appconfig.ff+json;charset=utf-8",
 }].map(createMockedKeyValue).concat([
     createMockedFeatureFlag("Beta", true),
     createMockedFeatureFlag("Alpha_1", true),
@@ -86,4 +125,36 @@ describe("feature flags", function () {
         expect((featureFlags as []).length).equals(2);
     });
 
+    it("should parse variant", async () => {
+        const connectionString = createMockedConnectionString();
+        const settings = await load(connectionString, {
+            featureFlagOptions: {
+                enabled: true,
+                selectors: [{
+                    keyFilter: "variant"
+                }]
+            }
+        });
+        expect(settings).not.undefined;
+        expect(settings.get("feature_management")).not.undefined;
+        const featureFlags = settings.get<any>("feature_management").feature_flags;
+        expect(featureFlags).not.undefined;
+        expect((featureFlags as []).length).equals(1);
+        const variant = featureFlags[0];
+        expect(variant).not.undefined;
+        expect(variant.id).equals("variant");
+        expect(variant.variants).not.undefined;
+        expect(variant.variants.length).equals(2);
+        expect(variant.variants[0].configuration_value).equals(false);
+        expect(variant.variants[1].configuration_value).equals(true);
+        expect(variant.allocation).not.undefined;
+        expect(variant.allocation.percentile).not.undefined;
+        expect(variant.allocation.percentile.length).equals(2);
+        expect(variant.allocation.percentile[0].variant).equals("Off");
+        expect(variant.allocation.percentile[1].variant).equals("On");
+        expect(variant.allocation.default_when_enabled).equals("Off");
+        expect(variant.allocation.default_when_disabled).equals("Off");
+        expect(variant.telemetry).not.undefined;
+    });
+
 });