Skip to content

Commit 6411a30

Browse files
committed
extract requestTraceOptions as private member
1 parent c29d834 commit 6411a30

File tree

1 file changed

+11
-20
lines changed

1 file changed

+11
-20
lines changed

src/AzureAppConfigurationImpl.ts

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,14 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
155155
return this.#featureFlagEnabled && !!this.#options?.featureFlagOptions?.refresh?.enabled;
156156
}
157157

158+
get #requestTraceOptions() {
159+
return {
160+
requestTracingEnabled: this.#requestTracingEnabled,
161+
initialLoadCompleted: this.#isInitialLoadCompleted,
162+
appConfigOptions: this.#options
163+
};
164+
}
165+
158166
async #loadSelectedKeyValues(): Promise<ConfigurationSetting[]> {
159167
const loadedSettings: ConfigurationSetting[] = [];
160168

@@ -167,13 +175,8 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
167175
labelFilter: selector.labelFilter
168176
};
169177

170-
const requestTraceOptions = {
171-
requestTracingEnabled: this.#requestTracingEnabled,
172-
initialLoadCompleted: this.#isInitialLoadCompleted,
173-
appConfigOptions: this.#options
174-
};
175178
const settings = listConfigurationSettingsWithTrace(
176-
requestTraceOptions,
179+
this.#requestTraceOptions,
177180
this.#client,
178181
listOptions
179182
);
@@ -214,7 +217,6 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
214217

215218
async #loadSelectedAndWatchedKeyValues() {
216219
const keyValues: [key: string, value: unknown][] = [];
217-
218220
const loadedSettings = await this.#loadSelectedKeyValues();
219221
await this.#updateWatchedKeyValuesEtag(loadedSettings);
220222

@@ -247,13 +249,8 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
247249
keyFilter: `${featureFlagPrefix}${selector.keyFilter}`,
248250
labelFilter: selector.labelFilter
249251
};
250-
const requestTraceOptions = {
251-
requestTracingEnabled: this.#requestTracingEnabled,
252-
initialLoadCompleted: this.#isInitialLoadCompleted,
253-
appConfigOptions: this.#options
254-
};
255252
const settings = listConfigurationSettingsWithTrace(
256-
requestTraceOptions,
253+
this.#requestTraceOptions,
257254
this.#client,
258255
listOptions
259256
);
@@ -474,18 +471,12 @@ export class AzureAppConfigurationImpl implements AzureAppConfiguration {
474471
async #getConfigurationSetting(configurationSettingId: ConfigurationSettingId, customOptions?: GetConfigurationSettingOptions): Promise<GetConfigurationSettingResponse | undefined> {
475472
let response: GetConfigurationSettingResponse | undefined;
476473
try {
477-
const requestTraceOptions = {
478-
requestTracingEnabled: this.#requestTracingEnabled,
479-
initialLoadCompleted: this.#isInitialLoadCompleted,
480-
appConfigOptions: this.#options
481-
};
482474
response = await getConfigurationSettingWithTrace(
483-
requestTraceOptions,
475+
this.#requestTraceOptions,
484476
this.#client,
485477
configurationSettingId,
486478
customOptions
487479
);
488-
489480
} catch (error) {
490481
if (error instanceof RestError && error.statusCode === 404) {
491482
response = undefined;

0 commit comments

Comments
 (0)