From 5174b41d5da5ffa1d66af6c2d4a46da9632dc705 Mon Sep 17 00:00:00 2001 From: MaxGraey Date: Wed, 15 Sep 2021 10:56:02 +0300 Subject: [PATCH 1/4] remove experimental-bigint v8 flags --- tests/compiler.js | 2 -- tests/features.json | 7 ++----- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/tests/compiler.js b/tests/compiler.js index b641f3954c..affd483713 100644 --- a/tests/compiler.js +++ b/tests/compiler.js @@ -342,7 +342,6 @@ function runTest(basename) { } let rtracedBuffer = stdout.toBuffer(); const instantiateRtrace = section("instantiate rtrace"); - v8.setFlagsFromString("--experimental-wasm-bigint"); if (!testInstantiate(basename, rtracedBuffer, glue, stderr, config.asc_wasi)) { failed = true; failedTests.add(basename); @@ -350,7 +349,6 @@ function runTest(basename) { } else { instantiateRtrace.end(SUCCESS); } - v8.setFlagsFromString("--no-experimental-wasm-bigint"); }); }); if (failed) return 1; diff --git a/tests/features.json b/tests/features.json index 92adbebdef..07322b22df 100644 --- a/tests/features.json +++ b/tests/features.json @@ -1,6 +1,8 @@ { "mutable-globals": { }, + "bigint-integration": { + }, "nontrapping-f2i": { "asc_flags": [ "--enable nontrapping-f2i" @@ -40,11 +42,6 @@ "--experimental-wasm-gc" ] }, - "bigint-integration": { - "v8_flags": [ - "--experimental-wasm-bigint" - ] - }, "exception-handling": { "asc_flags": [ "--enable exception-handling" From c27673badcc0e194f65ceb14c2da0e804c8e54ae Mon Sep 17 00:00:00 2001 From: MaxGraey Date: Wed, 15 Sep 2021 13:20:49 +0300 Subject: [PATCH 2/4] remove from all other places --- .github/workflows/test.yml | 2 +- tests/compiler/features/js-bigint-integration.json | 3 --- tests/compiler/std-wasi/console.json | 5 +---- tests/compiler/std-wasi/crypto.json | 5 +---- tests/compiler/std-wasi/process.json | 5 +---- tests/features.json | 2 -- 6 files changed, 4 insertions(+), 18 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 08ef13e467..65edd4edeb 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -123,7 +123,7 @@ jobs: run: npm run clean - name: Test experimental features env: - ASC_FEATURES: mutable-globals,threads,reference-types,bigint-integration,gc + ASC_FEATURES: mutable-globals,threads,reference-types,gc run: | npm run test:compiler rt/flags features/js-bigint-integration features/reference-types features/threads std-wasi/process std-wasi/crypto test-runtimes: diff --git a/tests/compiler/features/js-bigint-integration.json b/tests/compiler/features/js-bigint-integration.json index e8e76ac898..1b3c185bda 100644 --- a/tests/compiler/features/js-bigint-integration.json +++ b/tests/compiler/features/js-bigint-integration.json @@ -1,7 +1,4 @@ { - "features": [ - "bigint-integration" - ], "asc_flags": [ "--explicitStart" ] diff --git a/tests/compiler/std-wasi/console.json b/tests/compiler/std-wasi/console.json index cce2bd869a..055499a227 100644 --- a/tests/compiler/std-wasi/console.json +++ b/tests/compiler/std-wasi/console.json @@ -6,8 +6,5 @@ "args": [], "env": {}, "returnOnExit": true - }, - "features": [ - "bigint-integration" - ] + } } diff --git a/tests/compiler/std-wasi/crypto.json b/tests/compiler/std-wasi/crypto.json index cce2bd869a..055499a227 100644 --- a/tests/compiler/std-wasi/crypto.json +++ b/tests/compiler/std-wasi/crypto.json @@ -6,8 +6,5 @@ "args": [], "env": {}, "returnOnExit": true - }, - "features": [ - "bigint-integration" - ] + } } diff --git a/tests/compiler/std-wasi/process.json b/tests/compiler/std-wasi/process.json index ca8bfd0d09..df8245e87f 100644 --- a/tests/compiler/std-wasi/process.json +++ b/tests/compiler/std-wasi/process.json @@ -14,8 +14,5 @@ "THIRDENV": "thirdEnv" }, "returnOnExit": true - }, - "features": [ - "bigint-integration" - ] + } } diff --git a/tests/features.json b/tests/features.json index 07322b22df..e977a9158f 100644 --- a/tests/features.json +++ b/tests/features.json @@ -1,8 +1,6 @@ { "mutable-globals": { }, - "bigint-integration": { - }, "nontrapping-f2i": { "asc_flags": [ "--enable nontrapping-f2i" From f08dfd488e3b1ef32a6bb0d0df385bd277ccac5f Mon Sep 17 00:00:00 2001 From: MaxGraey Date: Wed, 15 Sep 2021 13:22:27 +0300 Subject: [PATCH 3/4] remov mut globals from ci --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 65edd4edeb..88a1d7bd5d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -123,7 +123,7 @@ jobs: run: npm run clean - name: Test experimental features env: - ASC_FEATURES: mutable-globals,threads,reference-types,gc + ASC_FEATURES: threads,reference-types,gc run: | npm run test:compiler rt/flags features/js-bigint-integration features/reference-types features/threads std-wasi/process std-wasi/crypto test-runtimes: From 0aacf54c8e0c36085e2223303ae20bf1beca7b7f Mon Sep 17 00:00:00 2001 From: MaxGraey Date: Wed, 15 Sep 2021 13:42:28 +0300 Subject: [PATCH 4/4] revert --- .github/workflows/test.yml | 2 +- tests/compiler/features/js-bigint-integration.json | 3 +++ tests/compiler/std-wasi/console.json | 5 ++++- tests/compiler/std-wasi/crypto.json | 5 ++++- tests/compiler/std-wasi/process.json | 5 ++++- tests/features.json | 2 ++ 6 files changed, 18 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 88a1d7bd5d..649ae45cb5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -123,7 +123,7 @@ jobs: run: npm run clean - name: Test experimental features env: - ASC_FEATURES: threads,reference-types,gc + ASC_FEATURES: threads,reference-types,bigint-integration,gc run: | npm run test:compiler rt/flags features/js-bigint-integration features/reference-types features/threads std-wasi/process std-wasi/crypto test-runtimes: diff --git a/tests/compiler/features/js-bigint-integration.json b/tests/compiler/features/js-bigint-integration.json index 1b3c185bda..e8e76ac898 100644 --- a/tests/compiler/features/js-bigint-integration.json +++ b/tests/compiler/features/js-bigint-integration.json @@ -1,4 +1,7 @@ { + "features": [ + "bigint-integration" + ], "asc_flags": [ "--explicitStart" ] diff --git a/tests/compiler/std-wasi/console.json b/tests/compiler/std-wasi/console.json index 055499a227..cce2bd869a 100644 --- a/tests/compiler/std-wasi/console.json +++ b/tests/compiler/std-wasi/console.json @@ -6,5 +6,8 @@ "args": [], "env": {}, "returnOnExit": true - } + }, + "features": [ + "bigint-integration" + ] } diff --git a/tests/compiler/std-wasi/crypto.json b/tests/compiler/std-wasi/crypto.json index 055499a227..cce2bd869a 100644 --- a/tests/compiler/std-wasi/crypto.json +++ b/tests/compiler/std-wasi/crypto.json @@ -6,5 +6,8 @@ "args": [], "env": {}, "returnOnExit": true - } + }, + "features": [ + "bigint-integration" + ] } diff --git a/tests/compiler/std-wasi/process.json b/tests/compiler/std-wasi/process.json index df8245e87f..ca8bfd0d09 100644 --- a/tests/compiler/std-wasi/process.json +++ b/tests/compiler/std-wasi/process.json @@ -14,5 +14,8 @@ "THIRDENV": "thirdEnv" }, "returnOnExit": true - } + }, + "features": [ + "bigint-integration" + ] } diff --git a/tests/features.json b/tests/features.json index e977a9158f..07322b22df 100644 --- a/tests/features.json +++ b/tests/features.json @@ -1,6 +1,8 @@ { "mutable-globals": { }, + "bigint-integration": { + }, "nontrapping-f2i": { "asc_flags": [ "--enable nontrapping-f2i"