From 33cef3993d76b8172bba71c346e4ba841b3c0cc2 Mon Sep 17 00:00:00 2001 From: MaxGraey Date: Sat, 24 Jul 2021 18:14:24 +0300 Subject: [PATCH 1/2] remove checking author in PRs --- .github/PULL_REQUEST_TEMPLATE.md | 3 ++- .github/workflows/test.yml | 14 -------------- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ad286f4976..1fc427f4bc 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -7,4 +7,5 @@ ⯈ ⯈ -- [ ] I've read the contributing guidelines \ No newline at end of file +- [ ] I've read the contributing guidelines +- [ ] I've added my name and email into NOTICE file diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e7208c082f..ff82848b51 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -10,20 +10,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v1.0.0 - - name: "Check that author is present in the NOTICE file" - if: github.event_name == 'pull_request' - run: | - AUTHOR=$(git log -1 --format="%aE") - if [ -z "$AUTHOR" ]; then - printf "\Cannot perform NOTICE check: Commit does not include an email address.\n" && - exit 1; - elif ! grep -q "$AUTHOR" NOTICE || false; then - printf "\nAuthor '$AUTHOR' does not appear to be listed in the NOTICE file, yet.\n" && - printf "Please see https://github.com/AssemblyScript/assemblyscript/blob/main/CONTRIBUTING.md\n" && - exit 1; - else - printf "\nOK: Author is present in the NOTICE file.\n"; - fi - name: "Check that distribution files are unmodified" if: github.event_name == 'pull_request' run: | From 6e64038a6c0b309d81feb898d2e66aacc0b81e86 Mon Sep 17 00:00:00 2001 From: Max Graey Date: Sat, 24 Jul 2021 18:17:02 +0300 Subject: [PATCH 2/2] Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Daniel Wirtz --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 1fc427f4bc..d82a076732 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -8,4 +8,4 @@ ⯈ - [ ] I've read the contributing guidelines -- [ ] I've added my name and email into NOTICE file +- [ ] I've added my name and email to the NOTICE file