From b1c3b92bf3916c86b6b80bc96a9667bb004ce91a Mon Sep 17 00:00:00 2001 From: yjhmelody Date: Thu, 15 Jul 2021 14:20:54 +0800 Subject: [PATCH 1/3] feat: do checkDiagnostics after `afterCompile` --- cli/asc.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/cli/asc.js b/cli/asc.js index 9b30cac365..02463bce96 100644 --- a/cli/asc.js +++ b/cli/asc.js @@ -864,6 +864,14 @@ exports.main = function main(argv, options, callback) { if (error) return callback(error); } + numErrors = checkDiagnostics(program, stderr, options.reportDiagnostic); + if (numErrors) { + if (module) module.dispose(); + const err = Error(numErrors + "afterCompile stage error(s)"); + err.stack = err.message; // omit stack + return callback(err); + } + // Validate the module if requested if (!opts.noValidate) { stats.validateCount++; From 7326c16e4727e9cb45c7173a2e8829b5a89ee8e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?d=CC=B6c=CC=B6o=CC=B6d=CC=B6e=CC=B6?= Date: Tue, 14 Sep 2021 23:14:45 +0200 Subject: [PATCH 2/3] Update asc.js --- cli/asc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/asc.js b/cli/asc.js index 02463bce96..43d70c6455 100644 --- a/cli/asc.js +++ b/cli/asc.js @@ -867,7 +867,7 @@ exports.main = function main(argv, options, callback) { numErrors = checkDiagnostics(program, stderr, options.reportDiagnostic); if (numErrors) { if (module) module.dispose(); - const err = Error(numErrors + "afterCompile stage error(s)"); + const err = Error(numErrors + " afterCompile error(s)"); err.stack = err.message; // omit stack return callback(err); } From 8fbb95cb2c5948fd3b929d24ab800beb292dbdc8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?d=CC=B6c=CC=B6o=CC=B6d=CC=B6e=CC=B6?= Date: Tue, 14 Sep 2021 23:18:10 +0200 Subject: [PATCH 3/3] Update asc.js --- cli/asc.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/asc.js b/cli/asc.js index 43d70c6455..5b3b6d966e 100644 --- a/cli/asc.js +++ b/cli/asc.js @@ -867,7 +867,7 @@ exports.main = function main(argv, options, callback) { numErrors = checkDiagnostics(program, stderr, options.reportDiagnostic); if (numErrors) { if (module) module.dispose(); - const err = Error(numErrors + " afterCompile error(s)"); + const err = Error(`${numErrors} afterCompile error(s)`); err.stack = err.message; // omit stack return callback(err); }