fix: Internal field names should use instance notation (#2056)

Author: dcodeIO

src/program.ts

@@ -3284,7 +3284,7 @@ export abstract class VariableLikeElement extends TypedElement {
     super(
       kind,
       name,
-      mangleInternalName(name, parent, false),
+      mangleInternalName(name, parent, declaration.is(CommonFlags.INSTANCE)),
       parent.program,
       parent,
       declaration

tests/compiler/field-initialization-errors.json

@@ -2,18 +2,18 @@
   "asc_flags": [
   ],
   "stderr": [
-    "TS2564: Property 'field-initialization-errors/Ref.a' has no initializer",
-    "TS2564: Property 'field-initialization-errors/Ref_Ctor.a' has no initializer",
-    "TS2564: Property 'field-initialization-errors/Ref_InlineCtor.a' has no initializer",
-    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Branch.a' has no initializer",
-    "TS2565: Property 'field-initialization-errors/Ref_Ctor_Use_Init.a' is used before being assigned.",
-    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Call_Init.a' has no initializer",
-    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Prop_Init.a' has no initializer",
-    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Callwith_Init.a' has no initializer",
-    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Alias_Init.a' has no initializer",
-    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Assign_Init.a' has no initializer",
-    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Icallwith_Init.a' has no initializer",
-    "TS2564: Property 'field-initialization-errors/Inherit_Base.a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Ref#a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Ref_Ctor#a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Ref_InlineCtor#a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Branch#a' has no initializer",
+    "TS2565: Property 'field-initialization-errors/Ref_Ctor_Use_Init#a' is used before being assigned.",
+    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Call_Init#a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Prop_Init#a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Callwith_Init#a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Alias_Init#a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Assign_Init#a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Ref_Ctor_Icallwith_Init#a' has no initializer",
+    "TS2564: Property 'field-initialization-errors/Inherit_Base#a' has no initializer",
     "EOF"
   ]
 }

tests/compiler/field-initialization-warnings.json

@@ -3,7 +3,7 @@
   ],
   "stderr": [
     "AS906: Unnecessary definite assignment.",
-    "AS233: Property 'field-initialization-warnings/Ref_Ctor_Init.a' is always assigned",
+    "AS233: Property 'field-initialization-warnings/Ref_Ctor_Init#a' is always assigned",
     "EOF"
   ]
 }

tests/compiler/field.json

@@ -0,0 +1,5 @@
+{
+  "asc_flags": [
+  ],
+  "asc_rtrace": true
+}