Exclude inherited fields for error reporting

Author: saulecabrera

src/compiler.ts

@@ -1544,7 +1544,7 @@ export class Compiler extends DiagnosticEmitter {
     if (instanceMembers) {
       for (let _values = Map_values(instanceMembers), i = 0, k = _values.length; i < k; ++i) {
         const element = unchecked(_values[i]);
-        if (element.kind == ElementKind.FIELD) {
+        if (element.kind == ElementKind.FIELD && element.parent == instance) {
           const field = <Field>element;
           if (!flow.isFieldFlag(field.internalName, FieldFlags.INITIALIZED)) {
             this.error(
@@ -10038,7 +10038,7 @@ export class Compiler extends DiagnosticEmitter {
       let fieldPrototype = field.prototype;
       let initializerNode = fieldPrototype.initializerNode;
       let parameterIndex = fieldPrototype.parameterIndex;
-      let initExpr: ExpressionRef | null = null;
+      let initExpr: ExpressionRef = -1;
       const isDefiniteAssigment = field.is(CommonFlags.DEFINITE_ASSIGNMENT);
 
       // if declared as a constructor parameter, use its value
@@ -10064,7 +10064,7 @@ export class Compiler extends DiagnosticEmitter {
         initExpr = this.makeZero(fieldType);
       }
 
-      if (initExpr) {
+      if (initExpr >= 0) {
         stmts.push(
           module.store(fieldType.byteSize,
             module.local_get(thisLocalIndex, nativeSizeType),

tests/compiler/strict-init.ts

@@ -1,6 +1,7 @@
 // OK - Field with explicit initializer
 export class WithInitializer {
   public a: i32 = 1;
+  some: string | null = null;
 }
 
 // ERR - Field b not initialized
@@ -23,6 +24,7 @@ export class ExplicitConstructorInit {
   }
 }
 
+// ERR - Left block empty
 export class EmptyLeftBlock {
   fieldLeft: i32;
 
@@ -34,6 +36,7 @@ export class EmptyLeftBlock {
   }
 }
 
+// ERR - Right block empty
 export class EmptyRightBlock {
   fieldRight: i32;
 
@@ -45,6 +48,7 @@ export class EmptyRightBlock {
   }
 }
 
+// ERR - Indefinite
 export class NonDefiniteIf {
   p: f64;
   constructor(a: i32) {
@@ -56,6 +60,7 @@ export class NonDefiniteIf {
   }
 }
 
+// OK - All branches covered
 export class DefiniteIf {
   definite: i32;
 
@@ -73,9 +78,29 @@ export class DefiniteIf {
 }
 
 
-class Inlined {
-  inlinedProp: i32;
-  constructor() {}
+// ERR
+export class Inlined {
+  inlinedProp: string | null;
 }
 
 new Inlined();
+
+// OK - inherited fields
+class ElementKind {}
+
+export abstract class Y {
+  inherited: string | null = "the inherited string";
+}
+
+export abstract class X extends Y {
+  ax: string[] | null;
+  protected constructor(public kind: ElementKind, other: ElementKind | null) {
+    super();
+
+    if (other) {
+      this.ax = ["string"];
+    } else {
+      this.ax = ["string", "string"];
+    }
+  }
+}