-
Notifications
You must be signed in to change notification settings - Fork 146
Code generation: update services and models #1545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces an automated update to the client library, incorporating the latest changes from the OpenAPI specification. The most notable enhancement is the expanded support for various local bank account identification types within the BankAccountAccountIdentification schema, which will facilitate broader international banking operations. Additionally, the update includes extensive code formatting and import reordering across multiple files, contributing to overall code quality and maintainability.
Highlights
- Expanded Bank Account Identification Support: The generated code now supports a significantly broader range of local bank account identification types, enhancing compatibility for various regions including Australia, Brazil, Canada, Czech Republic, Denmark, Hong Kong, Hungary, Norway, New Zealand, Poland, Sweden, Singapore, United Kingdom, and United States.
- Code Formatting and Import Optimization: Numerous files across both
acswebhooksandbalanceplatformmodules have undergone general code formatting and import reordering, improving code readability and consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated update from an OpenAPI specification. The changes are primarily formatting adjustments across a large number of model and service files, such as indentation, line breaks, and Javadoc comment styling. The most significant change is in BankAccountAccountIdentification.java, which now implements a oneOf schema with a custom serializer and deserializer, a standard pattern for generated code. After a thorough review, the changes seem correct and consistent with an automated tool run, and I found no functional issues or bugs.
e3db8ca to
1b40df1
Compare
24c9eca to
7a2e841
Compare
45ea8e6 to
5e219aa
Compare
Features 💎
Checkout API
encryptedPasswordattribute inCardDetailsResponseAdditionalDataSwishTerminal API
ScanBarcodeResultevent typeManagement API
unreferencedattribute inRefunds