-
Notifications
You must be signed in to change notification settings - Fork 146
Code generation: update services and models #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request delivers an automated update to the generated client code for Adyen's services and models, stemming from modifications in the underlying OpenAPI specification. The most significant functional improvement is a refinement in how polymorphic bank account identification types are deserialized, leading to more reliable data handling. Beyond this, the changes are largely cosmetic, encompassing formatting adjustments and import reordering, consistent with routine code generation updates.
Highlights
- Automated Code Generation Update: This pull request is an automated update of the generated client code for Adyen's services and models, reflecting recent changes in the OpenAPI specification.
- Improved Polymorphic Deserialization: The deserialization logic for various bank account identification types (e.g., AU, BR, CA, IBAN local accounts) has been enhanced to ensure more robust and accurate handling of polymorphic data structures based on the 'type' field.
- Code Formatting and Imports: The majority of changes across numerous files are related to code formatting, reordering of import statements, and minor adjustments to Javadoc comments, which are typical outcomes of an automated code generation process.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated update from an OpenAPI specification, primarily involving formatting changes across numerous Java model and handler classes. While most changes are stylistic, I've identified a few areas for improvement:
- Code Simplification: In
AcsWebhooksHandler, the logic for verifying webhook event types can be made more concise and efficient. - Code Readability: Several
hashCodemethods have been collapsed into a single long line, which harms readability. I've suggested reformatting these to be more maintainable. - Javadoc Formatting: There are widespread instances of malformed Javadoc comments, which I've pointed out with a suggestion for a fix.
Addressing these points will improve the overall quality and maintainability of the generated code.
OpenAPI spec files or templates have been modified on 07-08-2025 by commit.
Checkout API
actionattribute (PaymentDetailsResponseAction) inPaymentDetailsResponse