BalancePlatform TransferLimits: update order of path params for deletePendingTransferLimit and getSpecificTransferLimit (#1583)

* Invert order of parameters

* Rename variables

* Code format

Author: gcatanese

src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApi.java

@@ -63,7 +63,6 @@ public TransferLimitsBalanceAccountLevelApi(Client client, String baseURL) {
    *
    * @param id {@link String } The unique identifier of the balance account. (required)
    * @param approveTransferLimitRequest {@link ApproveTransferLimitRequest } (required)
-   * @param approveTransferLimitRequest {@link ApproveTransferLimitRequest } (required)
    * @throws ApiException if fails to make API call
    */
   public void approvePendingTransferLimits(
@@ -104,7 +103,6 @@ public void approvePendingTransferLimits(
    *
    * @param id {@link String } The unique identifier of the balance account. (required)
    * @param createTransferLimitRequest {@link CreateTransferLimitRequest } (required)
-   * @param createTransferLimitRequest {@link CreateTransferLimitRequest } (required)
    * @return {@link TransferLimit }
    * @throws ApiException if fails to make API call
    */
@@ -147,37 +145,37 @@ public TransferLimit createTransferLimit(
   /**
    * Delete a scheduled or pending transfer limit
    *
-   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param id {@link String } The unique identifier of the balance account. (required)
+   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @throws ApiException if fails to make API call
    */
-  public void deletePendingTransferLimit(String transferLimitId, String id)
+  public void deletePendingTransferLimit(String id, String transferLimitId)
       throws ApiException, IOException {
-    deletePendingTransferLimit(transferLimitId, id, null);
+    deletePendingTransferLimit(id, transferLimitId, null);
   }
 
   /**
    * Delete a scheduled or pending transfer limit
    *
-   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param id {@link String } The unique identifier of the balance account. (required)
+   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param requestOptions {@link RequestOptions } Object to store additional data such as
    *     idempotency-keys (optional)
    * @throws ApiException if fails to make API call
    */
   public void deletePendingTransferLimit(
-      String transferLimitId, String id, RequestOptions requestOptions)
+      String id, String transferLimitId, RequestOptions requestOptions)
       throws ApiException, IOException {
     // Add path params
     Map<String, String> pathParams = new HashMap<>();
-    if (transferLimitId == null) {
-      throw new IllegalArgumentException("Please provide the transferLimitId path parameter");
-    }
-    pathParams.put("transferLimitId", transferLimitId);
     if (id == null) {
       throw new IllegalArgumentException("Please provide the id path parameter");
     }
     pathParams.put("id", id);
+    if (transferLimitId == null) {
+      throw new IllegalArgumentException("Please provide the transferLimitId path parameter");
+    }
+    pathParams.put("transferLimitId", transferLimitId);
 
     String requestBody = null;
     Resource resource =
@@ -245,39 +243,39 @@ public TransferLimitListResponse getCurrentTransferLimits(
   /**
    * Get the details of a transfer limit
    *
-   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param id {@link String } The unique identifier of the balance account. (required)
+   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @return {@link TransferLimit }
    * @throws ApiException if fails to make API call
    */
-  public TransferLimit getSpecificTransferLimit(String transferLimitId, String id)
+  public TransferLimit getSpecificTransferLimit(String id, String transferLimitId)
       throws ApiException, IOException {
-    return getSpecificTransferLimit(transferLimitId, id, null);
+    return getSpecificTransferLimit(id, transferLimitId, null);
   }
 
   /**
    * Get the details of a transfer limit
    *
-   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param id {@link String } The unique identifier of the balance account. (required)
+   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param requestOptions {@link RequestOptions } Object to store additional data such as
    *     idempotency-keys (optional)
    * @return {@link TransferLimit }
    * @throws ApiException if fails to make API call
    */
   public TransferLimit getSpecificTransferLimit(
-      String transferLimitId, String id, RequestOptions requestOptions)
+      String id, String transferLimitId, RequestOptions requestOptions)
       throws ApiException, IOException {
     // Add path params
     Map<String, String> pathParams = new HashMap<>();
-    if (transferLimitId == null) {
-      throw new IllegalArgumentException("Please provide the transferLimitId path parameter");
-    }
-    pathParams.put("transferLimitId", transferLimitId);
     if (id == null) {
       throw new IllegalArgumentException("Please provide the id path parameter");
     }
     pathParams.put("id", id);
+    if (transferLimitId == null) {
+      throw new IllegalArgumentException("Please provide the transferLimitId path parameter");
+    }
+    pathParams.put("transferLimitId", transferLimitId);
 
     String requestBody = null;
     Resource resource =

src/main/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApi.java

@@ -63,7 +63,6 @@ public TransferLimitsBalancePlatformLevelApi(Client client, String baseURL) {
    *
    * @param id {@link String } The unique identifier of the balance platform. (required)
    * @param createTransferLimitRequest {@link CreateTransferLimitRequest } (required)
-   * @param createTransferLimitRequest {@link CreateTransferLimitRequest } (required)
    * @return {@link TransferLimit }
    * @throws ApiException if fails to make API call
    */
@@ -106,37 +105,37 @@ public TransferLimit createTransferLimit(
   /**
    * Delete a scheduled or pending transfer limit
    *
-   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param id {@link String } The unique identifier of the balance platform. (required)
+   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @throws ApiException if fails to make API call
    */
-  public void deletePendingTransferLimit(String transferLimitId, String id)
+  public void deletePendingTransferLimit(String id, String transferLimitId)
       throws ApiException, IOException {
-    deletePendingTransferLimit(transferLimitId, id, null);
+    deletePendingTransferLimit(id, transferLimitId, null);
   }
 
   /**
    * Delete a scheduled or pending transfer limit
    *
-   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param id {@link String } The unique identifier of the balance platform. (required)
+   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param requestOptions {@link RequestOptions } Object to store additional data such as
    *     idempotency-keys (optional)
    * @throws ApiException if fails to make API call
    */
   public void deletePendingTransferLimit(
-      String transferLimitId, String id, RequestOptions requestOptions)
+      String id, String transferLimitId, RequestOptions requestOptions)
       throws ApiException, IOException {
     // Add path params
     Map<String, String> pathParams = new HashMap<>();
-    if (transferLimitId == null) {
-      throw new IllegalArgumentException("Please provide the transferLimitId path parameter");
-    }
-    pathParams.put("transferLimitId", transferLimitId);
     if (id == null) {
       throw new IllegalArgumentException("Please provide the id path parameter");
     }
     pathParams.put("id", id);
+    if (transferLimitId == null) {
+      throw new IllegalArgumentException("Please provide the transferLimitId path parameter");
+    }
+    pathParams.put("transferLimitId", transferLimitId);
 
     String requestBody = null;
     Resource resource =
@@ -148,39 +147,39 @@ public void deletePendingTransferLimit(
   /**
    * Get the details of a transfer limit
    *
-   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param id {@link String } The unique identifier of the balance platform. (required)
+   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @return {@link TransferLimit }
    * @throws ApiException if fails to make API call
    */
-  public TransferLimit getSpecificTransferLimit(String transferLimitId, String id)
+  public TransferLimit getSpecificTransferLimit(String id, String transferLimitId)
       throws ApiException, IOException {
-    return getSpecificTransferLimit(transferLimitId, id, null);
+    return getSpecificTransferLimit(id, transferLimitId, null);
   }
 
   /**
    * Get the details of a transfer limit
    *
-   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param id {@link String } The unique identifier of the balance platform. (required)
+   * @param transferLimitId {@link String } The unique identifier of the transfer limit. (required)
    * @param requestOptions {@link RequestOptions } Object to store additional data such as
    *     idempotency-keys (optional)
    * @return {@link TransferLimit }
    * @throws ApiException if fails to make API call
    */
   public TransferLimit getSpecificTransferLimit(
-      String transferLimitId, String id, RequestOptions requestOptions)
+      String id, String transferLimitId, RequestOptions requestOptions)
       throws ApiException, IOException {
     // Add path params
     Map<String, String> pathParams = new HashMap<>();
-    if (transferLimitId == null) {
-      throw new IllegalArgumentException("Please provide the transferLimitId path parameter");
-    }
-    pathParams.put("transferLimitId", transferLimitId);
     if (id == null) {
       throw new IllegalArgumentException("Please provide the id path parameter");
     }
     pathParams.put("id", id);
+    if (transferLimitId == null) {
+      throw new IllegalArgumentException("Please provide the transferLimitId path parameter");
+    }
+    pathParams.put("transferLimitId", transferLimitId);
 
     String requestBody = null;
     Resource resource =

src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalanceAccountLevelApiTest.java

@@ -85,7 +85,7 @@ public void deletePendingTransferLimitTest() throws Exception {
     String balanceAccountId = "BA12345677890";
     String transferLimitId = "TRLI00000000000000000000000001";
 
-    service.deletePendingTransferLimit(transferLimitId, balanceAccountId);
+    service.deletePendingTransferLimit(balanceAccountId, transferLimitId);
     verify(client.getHttpClient())
         .request(
             "https://balanceplatform-api-test.adyen.com/bcl/v2/balanceAccounts/BA12345677890/transferLimits/TRLI00000000000000000000000001",
@@ -152,7 +152,7 @@ public void getSpecificTransferLimitTest() throws Exception {
     String transferLimitId = "TRLI00000000000000000000000001";
 
     TransferLimit transferLimit =
-        service.getSpecificTransferLimit(transferLimitId, balanceAccountId);
+        service.getSpecificTransferLimit(balanceAccountId, transferLimitId);
 
     verify(client.getHttpClient())
         .request(

src/test/java/com/adyen/service/balanceplatform/TransferLimitsBalancePlatformLevelApiTest.java

@@ -31,7 +31,7 @@ public void createTransferLimitTest() throws Exception {
     TransferLimitsBalancePlatformLevelApi service =
         new TransferLimitsBalancePlatformLevelApi(client);
 
-    String balanceAccountId = "BA12345677890";
+    String balancePlatform = "MY_BALANCE_PLATFORM";
     CreateTransferLimitRequest createTransferLimitRequest =
         new CreateTransferLimitRequest()
             .amount(new Amount().value(10000L).currency("EUR"))
@@ -43,11 +43,11 @@ public void createTransferLimitTest() throws Exception {
             .transferType(TransferType.ALL);
 
     TransferLimit transferLimit =
-        service.createTransferLimit(balanceAccountId, createTransferLimitRequest);
+        service.createTransferLimit(balancePlatform, createTransferLimitRequest);
 
     verify(client.getHttpClient())
         .request(
-            "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/BA12345677890/transferLimits",
+            "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/MY_BALANCE_PLATFORM/transferLimits",
             createTransferLimitRequest.toJson(),
             client.getConfig(),
             false,
@@ -64,14 +64,14 @@ public void deletePendingTransferLimitTest() throws Exception {
 
     TransferLimitsBalancePlatformLevelApi service =
         new TransferLimitsBalancePlatformLevelApi(client);
+    String balancePlatform = "MY_BALANCE_PLATFORM";
     String transferLimitId = "TRLI00000000000000000000000001";
-    String balanceAccountId = "BA12345677890";
 
-    service.deletePendingTransferLimit(transferLimitId, balanceAccountId);
+    service.deletePendingTransferLimit(balancePlatform, transferLimitId);
 
     verify(client.getHttpClient())
         .request(
-            "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/BA12345677890/transferLimits/TRLI00000000000000000000000001",
+            "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/MY_BALANCE_PLATFORM/transferLimits/TRLI00000000000000000000000001",
             null,
             client.getConfig(),
             false,
@@ -85,15 +85,15 @@ public void getSpecificTransferLimitTest() throws Exception {
     Client client = createMockClientFromFile("mocks/balancePlatform/TransferLimit.json");
     TransferLimitsBalancePlatformLevelApi service =
         new TransferLimitsBalancePlatformLevelApi(client);
-    String balanceAccountId = "BA12345677890";
+    String balancePlatform = "MY_BALANCE_PLATFORM";
     String transferLimitId = "TRLI00000000000000000000000001";
 
     TransferLimit transferLimit =
-        service.getSpecificTransferLimit(transferLimitId, balanceAccountId);
+        service.getSpecificTransferLimit(balancePlatform, transferLimitId);
 
     verify(client.getHttpClient())
         .request(
-            "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/BA12345677890/transferLimits/TRLI00000000000000000000000001",
+            "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/MY_BALANCE_PLATFORM/transferLimits/TRLI00000000000000000000000001",
             null,
             client.getConfig(),
             false,
@@ -109,13 +109,13 @@ public void getTransferLimitsTest() throws Exception {
     Client client = createMockClientFromFile("mocks/balancePlatform/TransferLimits.json");
     TransferLimitsBalancePlatformLevelApi service =
         new TransferLimitsBalancePlatformLevelApi(client);
-    String balanceAccountId = "BA12345677890";
+    String balancePlatform = "MY_BALANCE_PLATFORM";
 
-    TransferLimitListResponse transferLimits = service.getTransferLimits(balanceAccountId);
+    TransferLimitListResponse transferLimits = service.getTransferLimits(balancePlatform);
 
     verify(client.getHttpClient())
         .request(
-            "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/BA12345677890/transferLimits",
+            "https://balanceplatform-api-test.adyen.com/bcl/v2/balancePlatforms/MY_BALANCE_PLATFORM/transferLimits",
             null,
             client.getConfig(),
             false,