Skip to content

Conversation

@benedeki
Copy link
Collaborator

@benedeki benedeki commented Aug 22, 2021

This is a PR to bring the Enceladus 3 version currently under development to be en par with the recently released version 2.23.0 feature and bugfix wise.

benedeki and others added 21 commits June 6, 2021 20:04
* #1821 stripping blank properties is moved to DatasetService.cleanupEntity(), so it is not affected by `datasetEntity.{_properties|properties}`` differences.

* #1821 fixing properties being stripped away from DS on CR update (add/delete/move)
* #1821 stripping blank properties is moved to DatasetService.cleanupEntity(), so it is not affected by `datasetEntity.{_properties|properties}`` differences.

* #1821 fixing properties being stripped away from DS on CR update (add/delete/move)
…n case the source is already timestamp (#1841)

#1836: Standardization ignores timezone metadata for timestamp type in case the source is already timestamp
* Timezone in metadata is taken into account even if the source is already timestamp or date
* Added explanatory comment to the test
… a warning dialog (#1847)

* Show dialogs only on submit not in case of validation on the fly
* Show property warning only if all Mandatory has passed validation
* #1842 - DS Properties on DS dialog: layout tweaked, resizable (default: Small), enhanced tooltips, properties border
* 1705 showing all properties and if missing
* gitflow-maven-plugin update to 1.16.0

* PR review inspired plugin version names changed, removed the unused.
% Conflicts:
%	dao/pom.xml
%	data-model/pom.xml
%	examples/pom.xml
%	menas/pom.xml
%	migrations-cli/pom.xml
%	migrations/pom.xml
%	plugins-api/pom.xml
%	plugins-builtin/pom.xml
%	pom.xml
%	spark-jobs/pom.xml
%	utils/pom.xml
…1854)

#1853: Remove the warning of wrong browser type and version in Menas
* Changed the warning not to convey false information of certain compatibility of older browser versions
* Added detection of other browsers that should work
* Added warning for unrecognized browser

Co-authored-by: Adrian Olosutean <[email protected]>
#1835: Support multiple date formats in Helper scripts
* automatic universal date & time parsing regardless of locale in Windows helper scripts
* LF -> CRLF in *.cmd and *.bat files
* CRLF for *.cmd and *.bat files in editor
dk1844
dk1844 previously approved these changes Sep 16, 2021
Copy link
Contributor

@dk1844 dk1844 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just read the code; did not find anything suspicious)

@benedeki benedeki added the PR:no testing needed Only for PR - PR doesn't need to be tested by a tester (person) label Sep 18, 2021
* Adding back Menas module, that somehow got omitted.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@AdrianOlosutean AdrianOlosutean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried Menas locally, seems to work

@benedeki
Copy link
Collaborator Author

Tried Menas locally, seems to work

We will have to retest E3 thoroughly before release. A lot of tricky merges has been done on this branch. 😉

@benedeki benedeki merged commit bd39018 into develop-ver-3.0 Sep 20, 2021
@benedeki benedeki deleted the merge/release-2.23.-0-into-develop-ver-3 branch September 20, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:no testing needed Only for PR - PR doesn't need to be tested by a tester (person)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants