-
Notifications
You must be signed in to change notification settings - Fork 15
Merging Release 2.23. 0 into develop ver 3 #1890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging Release 2.23. 0 into develop ver 3 #1890
Conversation
Co-authored-by: Saša Zejnilović <[email protected]>
Co-authored-by: David Benedeki <[email protected]>
… a warning dialog (#1847) * Show dialogs only on submit not in case of validation on the fly * Show property warning only if all Mandatory has passed validation
Co-authored-by: David Benedeki <[email protected]>
* 1705 showing all properties and if missing
* gitflow-maven-plugin update to 1.16.0 * PR review inspired plugin version names changed, removed the unused.
% Conflicts: % dao/pom.xml % data-model/pom.xml % examples/pom.xml % menas/pom.xml % migrations-cli/pom.xml % migrations/pom.xml % plugins-api/pom.xml % plugins-builtin/pom.xml % pom.xml % spark-jobs/pom.xml % utils/pom.xml
…1854) #1853: Remove the warning of wrong browser type and version in Menas * Changed the warning not to convey false information of certain compatibility of older browser versions * Added detection of other browsers that should work * Added warning for unrecognized browser Co-authored-by: Adrian Olosutean <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (just read the code; did not find anything suspicious)
* Adding back Menas module, that somehow got omitted.
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried Menas locally, seems to work
We will have to retest E3 thoroughly before release. A lot of tricky merges has been done on this branch. 😉 |








This is a PR to bring the Enceladus 3 version currently under development to be en par with the recently released version 2.23.0 feature and bugfix wise.