Apply suggestions from code review

Co-authored-by: Hugues Kamba <[email protected]>

Author: rajkan01

CMakeLists.txt

@@ -124,7 +124,12 @@ add_subdirectory(cmsis/device/rtos EXCLUDE_FROM_ALL)
 # Configures the application
 #
 function(mbed_configure_app_target target)
-    mbed_set_language_standard(${target})
+    # Set the language standard to use per target
+    target_compile_features(${target}
+        PUBLIC
+            c_std_11
+            cxx_std_14
+    )
 endfunction()
 
 #

connectivity/drivers/mbedtls/FEATURE_CRYPTOCELL310/TARGET_MCU_NRF52840/CMakeLists.txt

@@ -2,14 +2,14 @@
 # SPDX-License-Identifier: Apache-2.0
 
 if(${MBED_TOOLCHAIN} STREQUAL "GCC_ARM")
-    set(LIBCC_310_EXT TOOLCHAIN_GCC_ARM/libcc_310_ext.a)
-    set(LIBCC_310_TRNG TOOLCHAIN_GCC_ARM/libcc_310_trng.a)
+    set(LIBCC_310_EXT ./TOOLCHAIN_GCC_ARM/libcc_310_ext.a)
+    set(LIBCC_310_TRNG ./TOOLCHAIN_GCC_ARM/libcc_310_trng.a)
 elseif(${MBED_TOOLCHAIN} STREQUAL "ARM")
-    set(LIBCC_310_EXT TOOLCHAIN_ARM/libcc_310_ext.ar)
-    set(LIBCC_310_TRNG TOOLCHAIN_ARM/libcc_310_trng.ar)
+    set(LIBCC_310_EXT ./TOOLCHAIN_ARM/libcc_310_ext.ar)
+    set(LIBCC_310_TRNG ./TOOLCHAIN_ARM/libcc_310_trng.ar)
 elseif(${MBED_TOOLCHAIN} STREQUAL "IAR")
-    set(LIBCC_310_EXT TOOLCHAIN_IAR/lib_cc310_ext.a)
-    set(LIBCC_310_TRNG TOOLCHAIN_IAR/lib_cc310_trng.a)
+    set(LIBCC_310_EXT ./TOOLCHAIN_IAR/lib_cc310_ext.a)
+    set(LIBCC_310_TRNG ./TOOLCHAIN_IAR/lib_cc310_trng.a)
 endif()
 
 target_include_directories(mbed-mbedtls-cryptocell310
@@ -24,6 +24,6 @@ target_sources(mbed-mbedtls-cryptocell310
 
 target_link_libraries(mbed-mbedtls-cryptocell310
     INTERFACE
-        ./${LIBCC_310_EXT}
-        ./${LIBCC_310_TRNG}
+        ${LIBCC_310_EXT}
+        ${LIBCC_310_TRNG}
 )

connectivity/drivers/mbedtls/FEATURE_CRYPTOCELL310/binaries/CMakeLists.txt

@@ -2,14 +2,14 @@
 # SPDX-License-Identifier: Apache-2.0
 
 if(${MBED_TOOLCHAIN} STREQUAL "GCC_ARM")
-    set(LIBCC_310_CORE TOOLCHAIN_GCC_ARM/libcc_310_core.a)
+    set(LIBCC_310_CORE ./TOOLCHAIN_GCC_ARM/libcc_310_core.a)
 elseif(${MBED_TOOLCHAIN} STREQUAL "ARM")
-    set(LIBCC_310_CORE TOOLCHAIN_ARM/libcc_310_core.ar)
+    set(LIBCC_310_CORE ./TOOLCHAIN_ARM/libcc_310_core.ar)
 elseif(${MBED_TOOLCHAIN} STREQUAL "IAR")
-    set(LIBCC_310_CORE TOOLCHAIN_IAR/lib_cc310_ext.a)
+    set(LIBCC_310_CORE ./TOOLCHAIN_IAR/lib_cc310_ext.a)
 endif()
 
 target_link_libraries(mbed-mbedtls-cryptocell310
     INTERFACE
-        ${CMAKE_CURRENT_SOURCE_DIR}/${LIBCC_310_CORE}
+        ${LIBCC_310_CORE}
 )

tools/cmake/toolchain.cmake

@@ -46,15 +46,6 @@ set(CMAKE_CROSSCOMPILING TRUE)
 set(CMAKE_C_COMPILER_WORKS TRUE)
 set(CMAKE_CXX_COMPILER_WORKS TRUE)
 
-# Set the language standard to use per target
-function(mbed_set_language_standard target)
-    target_compile_features(${target}
-        INTERFACE
-            c_std_11
-            cxx_std_14
-    )
-endfunction()
-
 # Clear toolchains options for all languages as Mbed OS uses
 # different initialisation options (such as for optimization and debug symbols)
 set(CMAKE_C_FLAGS_DEBUG "" CACHE STRING "" FORCE)