8291924: jpackage: l10n for Windows context menu label

Reviewed-by: naoto, asemenyuk, almatvee

Author: akashche

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixAppImageFragmentBuilder.java

@@ -528,7 +528,7 @@ private List<String> addFaComponents(XMLStreamWriter xml,
 
                 xml.writeStartElement("Verb");
                 xml.writeAttribute("Id", "open");
-                xml.writeAttribute("Command", "Open");
+                xml.writeAttribute("Command", "!(loc.ContextMenuCommandLabel)");
                 xml.writeAttribute("Argument", "\"%1\" %*");
                 xml.writeAttribute("TargetFile", Id.File.of(fa.launcherPath));
                 xml.writeEndElement(); // <Verb>

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl

@@ -12,4 +12,5 @@
   <String Id="ShortcutPromptDlgDesktopShortcutControlLabel">Desktopverknüpfung(en) erstellen</String>
   <String Id="ShortcutPromptDlgStartMenuShortcutControlLabel">Startmenüverknüpfung(en) erstellen</String>
   <String Id="InstallDirNotEmptyDlg_Title">[ProductName]-Setup</String>
+  <String Id="ContextMenuCommandLabel">Open with [ProductName]</String>
 </WixLocalization>

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_en.wxl

@@ -12,4 +12,5 @@
   <String Id="ShortcutPromptDlgDesktopShortcutControlLabel">Create desktop shortcut(s)</String>
   <String Id="ShortcutPromptDlgStartMenuShortcutControlLabel">Create start menu shortcut(s)</String>
   <String Id="InstallDirNotEmptyDlg_Title">[ProductName] Setup</String>
+  <String Id="ContextMenuCommandLabel">Open with [ProductName]</String>
 </WixLocalization>

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_ja.wxl

@@ -12,4 +12,5 @@
   <String Id="ShortcutPromptDlgDesktopShortcutControlLabel">デスクトップ・ショートカットの作成</String>
   <String Id="ShortcutPromptDlgStartMenuShortcutControlLabel">スタート・メニューのショートカットの作成</String>
   <String Id="InstallDirNotEmptyDlg_Title">[ProductName]セットアップ</String>
+  <String Id="ContextMenuCommandLabel">Open with [ProductName]</String>
 </WixLocalization>

src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_zh_CN.wxl

@@ -12,4 +12,5 @@
   <String Id="ShortcutPromptDlgDesktopShortcutControlLabel">创建桌面快捷方式</String>
   <String Id="ShortcutPromptDlgStartMenuShortcutControlLabel">创建开始菜单快捷方式</String>
   <String Id="InstallDirNotEmptyDlg_Title">[ProductName] 安装程序</String>
+  <String Id="ContextMenuCommandLabel">Open with [ProductName]</String>
 </WixLocalization>

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageTest.java

@@ -283,6 +283,18 @@ PackageTest addHelloAppFileAssociationsVerifier(FileAssociations fa) {
                 HelloApp.verifyOutputFile(appOutput, expectedArgs,
                         Collections.emptyMap());
             });
+
+            if (TKit.isWindows()) {
+                // Verify context menu label in registry.
+                String progId = WindowsHelper.queryRegistryValue(
+                        String.format("HKEY_LOCAL_MACHINE\\SOFTWARE\\Classes\\%s", fa.getSuffix()), "");
+                TKit.assertNotNull(progId, "context menu progId found");
+                String contextMenuLabel = WindowsHelper.queryRegistryValue(
+                        String.format("HKEY_CLASSES_ROOT\\%s\\shell\\open", progId), "");
+                TKit.assertNotNull(contextMenuLabel, "context menu label found");
+                String appName = cmd.getArgumentValue("--name");
+                TKit.assertTrue(String.format("Open with %s", appName).equals(contextMenuLabel), "context menu label text");
+            }
         });
 
         return this;

test/jdk/tools/jpackage/helpers/jdk/jpackage/test/WindowsHelper.java

@@ -356,7 +356,7 @@ private void verifyFileAssociations(boolean exists, String suffix,
         private final String name;
     }
 
-    private static String queryRegistryValue(String keyPath, String valueName) {
+    static String queryRegistryValue(String keyPath, String valueName) {
         var status = Executor.of("reg", "query", keyPath, "/v", valueName)
                 .saveOutput()
                 .executeWithoutExitCodeCheck();