Skip to content

Commit dcf431d

Browse files
afshin-zafarirobehn
authored andcommitted
8287400: Make BitMap range parameter names consistent
Reviewed-by: dholmes, lkorinth
1 parent a1f4db5 commit dcf431d

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

src/hotspot/share/utilities/bitMap.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,11 +320,11 @@ bool BitMap::par_at_put(idx_t bit, bool value) {
320320
return value ? par_set_bit(bit) : par_clear_bit(bit);
321321
}
322322

323-
void BitMap::at_put_range(idx_t start_offset, idx_t end_offset, bool value) {
323+
void BitMap::at_put_range(idx_t beg_offset, idx_t end_offset, bool value) {
324324
if (value) {
325-
set_range(start_offset, end_offset);
325+
set_range(beg_offset, end_offset);
326326
} else {
327-
clear_range(start_offset, end_offset);
327+
clear_range(beg_offset, end_offset);
328328
}
329329
}
330330

src/hotspot/share/utilities/bitMap.hpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,9 @@ class BitMap {
9797
// Helper for get_next_{zero,one}_bit variants.
9898
// - flip designates whether searching for 1s or 0s. Must be one of
9999
// find_{zeros,ones}_flip.
100-
// - aligned_right is true if r_index is a priori on a bm_word_t boundary.
100+
// - aligned_right is true if end is a priori on a bm_word_t boundary.
101101
template<bm_word_t flip, bool aligned_right>
102-
inline idx_t get_next_bit_impl(idx_t l_index, idx_t r_index) const;
102+
inline idx_t get_next_bit_impl(idx_t beg, idx_t end) const;
103103

104104
// Values for get_next_bit_impl flip parameter.
105105
static const bm_word_t find_ones_flip = 0;
@@ -262,11 +262,11 @@ class BitMap {
262262
template <class BitMapClosureType>
263263
bool iterate(BitMapClosureType* cl);
264264

265-
// Looking for 1's and 0's at indices equal to or greater than "l_index",
266-
// stopping if none has been found before "r_index", and returning
267-
// "r_index" (which must be at most "size") in that case.
268-
idx_t get_next_one_offset (idx_t l_index, idx_t r_index) const;
269-
idx_t get_next_zero_offset(idx_t l_index, idx_t r_index) const;
265+
// Looking for 1's and 0's at indices equal to or greater than "beg",
266+
// stopping if none has been found before "end", and returning
267+
// "end" (which must be at most "size") in that case.
268+
idx_t get_next_one_offset (idx_t beg, idx_t end) const;
269+
idx_t get_next_zero_offset(idx_t beg, idx_t end) const;
270270

271271
idx_t get_next_one_offset(idx_t offset) const {
272272
return get_next_one_offset(offset, size());
@@ -275,9 +275,9 @@ class BitMap {
275275
return get_next_zero_offset(offset, size());
276276
}
277277

278-
// Like "get_next_one_offset", except requires that "r_index" is
278+
// Like "get_next_one_offset", except requires that "end" is
279279
// aligned to bitsizeof(bm_word_t).
280-
idx_t get_next_one_offset_aligned_right(idx_t l_index, idx_t r_index) const;
280+
idx_t get_next_one_offset_aligned_right(idx_t beg, idx_t end) const;
281281

282282
// Returns the number of bits set in the bitmap.
283283
idx_t count_one_bits() const;

0 commit comments

Comments
 (0)