8068925: Add @OverRide in javax.tools classes

Reviewed-by: darcy, iris

Author: jonathan-gibbons

src/java.compiler/share/classes/javax/tools/DiagnosticCollector.java

@@ -47,6 +47,7 @@ public final class DiagnosticCollector<S> implements DiagnosticListener<S> {
      */
     public DiagnosticCollector() {}
 
+    @Override
     public void report(Diagnostic<? extends S> diagnostic) {
         Objects.requireNonNull(diagnostic);
         diagnostics.add(diagnostic);

src/java.compiler/share/classes/javax/tools/DocumentationTool.java

@@ -191,8 +191,10 @@ enum Location implements JavaFileManager.Location {
          */
         SNIPPET_PATH;
 
+        @Override
         public String getName() { return name(); }
 
+        @Override
         public boolean isOutputLocation() {
             switch (this) {
                 case DOCUMENTATION_OUTPUT:

src/java.compiler/share/classes/javax/tools/JavaCompiler.java

@@ -168,6 +168,7 @@
  *       JavaCompiler compiler = ToolProvider.getSystemJavaCompiler();
  *       StandardJavaFileManager stdFileManager = compiler.getStandardFileManager(null, null, null);
  *       JavaFileManager fileManager = new ForwardingJavaFileManager(stdFileManager) {
+ *           @Override
  *           public void flush() throws IOException {
  *               logger.entering(StandardJavaFileManager.class.getName(), "flush");
  *               super.flush();

src/java.compiler/share/classes/javax/tools/SimpleJavaFileObject.java

@@ -68,10 +68,12 @@ protected SimpleJavaFileObject(URI uri, Kind kind) {
         this.kind = kind;
     }
 
+    @Override
     public URI toUri() {
         return uri;
     }
 
+    @Override
     public String getName() {
         return toUri().getPath();
     }
@@ -82,6 +84,7 @@ public String getName() {
      * behavior as long as the contract of {@link FileObject} is
      * obeyed.
      */
+    @Override
     public InputStream openInputStream() throws IOException {
         throw new UnsupportedOperationException();
     }
@@ -92,6 +95,7 @@ public InputStream openInputStream() throws IOException {
      * behavior as long as the contract of {@link FileObject} is
      * obeyed.
      */
+    @Override
     public OutputStream openOutputStream() throws IOException {
         throw new UnsupportedOperationException();
     }
@@ -107,14 +111,13 @@ public OutputStream openOutputStream() throws IOException {
      * @throws UnsupportedOperationException {@inheritDoc}
      * @throws IOException {@inheritDoc}
      */
+    @Override
     public Reader openReader(boolean ignoreEncodingErrors) throws IOException {
         CharSequence charContent = getCharContent(ignoreEncodingErrors);
         if (charContent == null)
             throw new UnsupportedOperationException();
-        if (charContent instanceof CharBuffer) {
-            CharBuffer buffer = (CharBuffer)charContent;
-            if (buffer.hasArray())
-                return new CharArrayReader(buffer.array());
+        if (charContent instanceof CharBuffer buffer && buffer.hasArray()) {
+            return new CharArrayReader(buffer.array());
         }
         return new StringReader(charContent.toString());
     }
@@ -125,6 +128,7 @@ public Reader openReader(boolean ignoreEncodingErrors) throws IOException {
      * behavior as long as the contract of {@link FileObject} is
      * obeyed.
      */
+    @Override
     public CharSequence getCharContent(boolean ignoreEncodingErrors) throws IOException {
         throw new UnsupportedOperationException();
     }
@@ -139,6 +143,7 @@ public CharSequence getCharContent(boolean ignoreEncodingErrors) throws IOExcept
      * @throws UnsupportedOperationException {@inheritDoc}
      * @throws IOException {@inheritDoc}
      */
+    @Override
     public Writer openWriter() throws IOException {
         return new OutputStreamWriter(openOutputStream());
     }
@@ -150,6 +155,7 @@ public Writer openWriter() throws IOException {
      *
      * @return {@code 0L}
      */
+    @Override
     public long getLastModified() {
         return 0L;
     }
@@ -161,13 +167,15 @@ public long getLastModified() {
      *
      * @return {@code false}
      */
+    @Override
     public boolean delete() {
         return false;
     }
 
     /**
      * @return {@code this.kind}
      */
+    @Override
     public Kind getKind() {
         return kind;
     }
@@ -186,6 +194,7 @@ public Kind getKind() {
      * <p>Subclasses can change this behavior as long as the contract
      * of {@link JavaFileObject} is obeyed.
      */
+    @Override
     public boolean isNameCompatible(String simpleName, Kind kind) {
         String baseName = simpleName + kind.extension;
         return kind.equals(getKind())
@@ -198,13 +207,15 @@ public boolean isNameCompatible(String simpleName, Kind kind) {
      * change this behavior as long as the contract of
      * {@link JavaFileObject} is obeyed.
      */
+    @Override
     public NestingKind getNestingKind() { return null; }
 
     /**
      * This implementation returns {@code null}.  Subclasses can
      * change this behavior as long as the contract of
      * {@link JavaFileObject} is obeyed.
      */
+    @Override
     public Modifier getAccessLevel()  { return null; }
 
     @Override